jakarta-cactus-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felipe Leme (JIRA)" <cactus-...@jakarta.apache.org>
Subject [jira] Commented: (CACTUS-65) Improve cactifywar to check for cactus redirector duplications
Date Fri, 29 Dec 2006 01:00:22 GMT
    [ http://issues.apache.org/jira/browse/CACTUS-65?page=comments#action_12461285 ] 
            
Felipe Leme commented on CACTUS-65:
-----------------------------------

Hi Petar,

First of all, thanks for the patch.

Now, back to thte issue at hand, I'm not sure if it's a good idea to change the signature
of a public method just to log a warning. Two other options would be using Commons Logging
(declaring a protected logger instance in the Redirector class) or pass the Task in the constructor
of the Redirector class (and sub-classes) - this latter option might be more appropriate,
as we barely use Commons Logging (looks like it is used only on CookieUtil for debugging;
it that's the case, we could even remove that dependency).

What do you think?

-- Felipe



> Improve cactifywar to check for cactus redirector duplications
> --------------------------------------------------------------
>
>                 Key: CACTUS-65
>                 URL: http://issues.apache.org/jira/browse/CACTUS-65
>             Project: Cactus
>          Issue Type: Improvement
>          Components: Ant Integration
>    Affects Versions: 1.5-rc1
>         Environment: Operating System: Other
> Platform: Other
>            Reporter: Brett Porter
>         Attachments: CactifyWar.patch
>
>
> I finally bit the bullet and decided to get into Cactus to expand our unit
> testing horizons :)
> I started out by using
> http://jakarta.apache.org/cactus/integration/howto_tomcat.html to set up a
> Tomcat instance, putting the redirectors into the global web.xml.
> After doing the tutorial, I then tried the samples, and found Tomcat failed to
> start up. Running with ant -debug showed that it wasn't starting, so I checked
> the Tomcat logs and found that there was a duplicate definition on the
> redirectors because the samples use a cactified war.
> I'd suggest the quick start guide should place a warning in step 3 that says
> that if you do that, cactified wars may not work, including running the samples.
> Just a small addition to some fantastic documentation. 5 stars to all involved
> on the doco and tool support, it's really easy to work through and get started!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org


Mime
View raw message