Mailing-List: contact cactus-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Cactus Developers List" <cactus-dev@jakarta.apache.org>
Message-ID: <07ed01c34617$53db02c0$0b6fa8c0@jazz>
From: "Florin Vancea" <fvancea@maxiq.ro>
To: "Cactus Developers List" <cactus-dev@jakarta.apache.org>
References: <01ed01c344a2$92eea550$2502a8c0@vma>
Subject: Patch for JBoss starting too slow
Date: Wed, 9 Jul 2003 15:40:49 +0300
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_NextPart_000_07EA_01C34630.78E0AA70"

------=_NextPart_000_07EA_01C34630.78E0AA70
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit

The issue with JBoss starting too slow is still unsolved and I thought I'd
try something about that.

I am attaching a patch and the reasoning follows below.

When starting the container, ContainerRunner polls on a URL with the
isAvailable(URL) function. This function returns TRUE when it succeeds to
read from that URL, but it does not care if the reply was something like a
500 error.

Maybe that is OK for most containers, but when I'm trying on JBoss+Tomcat,
the startup sequence is: start embedded Tomcat first, then load and
configure the Cactified WAR (after some considerable delay).
The consequence is that the test URL seems to be available, but in fact is
merely returning the ERROR 500 page, since the Cactified context is still
loading.
Therefore, the sequence of tests is starting too soon and the first test
fails with another ERROR 500. In the meanwhile the context "wakes up" and
the following tests are OK. I have to mention that it's not test's fault.
The tests are running OK with an alerady-started, already-deployed setup.

I suggest that ContainerRunner.isAvailable(URL) should test also the result
code and I suspect it was meant to, but never got there.

I also attach a patch (not necessarily the best approach :) ).

Thanks,
Florin

P.S. Seems that the JMX bean that I posted earlier (last week) was not
considered a good approach by anyone. Some feedback would have been nice,
though. I hope this one _will_ get some kind of answer (any, including "quit
bugging us").

------=_NextPart_000_07EA_01C34630.78E0AA70
Content-Type: text/plain;
	name="patch.txt"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="patch.txt"

RCS file: =
/home/cvspublic/jakarta-cactus/integration/ant/src/java/org/apache/cactus=
/integration/ant/container/ContainerRunner.java,v
retrieving revision 1.3
diff -r1.3 ContainerRunner.java
353a354,357
>             if (connection.getResponseCode() !=3D -1 && =
connection.getResponseCode() < 300 )=20
>             {
>                 isUrlCallable =3D true;
>             }
355d358
<             isUrlCallable =3D true;


------=_NextPart_000_07EA_01C34630.78E0AA70
Content-Type: text/plain; charset=us-ascii

---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
------=_NextPart_000_07EA_01C34630.78E0AA70--