jakarta-cactus-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vmas...@apache.org
Subject cvs commit: jakarta-cactus/sample-servlet/src/unit/share/org/apache/cactus/unit TestServletTestCase2.java
Date Tue, 23 Jul 2002 22:07:52 GMT
vmassol     2002/07/23 15:07:52

  Modified:    framework/src/java/share/org/apache/cactus WebResponse.java
               sample-servlet/src/unit/share/org/apache/cactus/unit
                        TestServletTestCase2.java
  Log:
  refactored HttpClientHelper in ConnectionHelper + JdkConnectionHelper to allow different
implementations of HTTP connection. I plan to move to Commons HttpClient once I know for sure
I can wrap a HttpClient HttpMethod object in a HttpURLConnection one (which I have temporarily
added in util/ but I plan to donate it to the Commons HttpClient project).
  
  Revision  Changes    Path
  1.5       +5 -5      jakarta-cactus/framework/src/java/share/org/apache/cactus/WebResponse.java
  
  Index: WebResponse.java
  ===================================================================
  RCS file: /home/cvs/jakarta-cactus/framework/src/java/share/org/apache/cactus/WebResponse.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- WebResponse.java	22 Jul 2002 12:26:04 -0000	1.4
  +++ WebResponse.java	23 Jul 2002 22:07:52 -0000	1.5
  @@ -68,7 +68,7 @@
   import org.apache.commons.logging.Log;
   import org.apache.commons.logging.LogFactory;
   
  -import org.apache.cactus.client.HttpClientHelper;
  +import org.apache.cactus.client.JdkConnectionHelper;
   import org.apache.cactus.util.ChainedRuntimeException;
   import org.apache.cactus.util.IoUtil;
   
  @@ -246,11 +246,11 @@
                   org.apache.commons.httpclient.Cookie[] cookies;
                   try {
                       cookies = org.apache.commons.httpclient.Cookie.parse(
  -                        HttpClientHelper.getDomain(getWebRequest(),
  +                        JdkConnectionHelper.getDomain(getWebRequest(),
                               getConnection()),
  -                        HttpClientHelper.getPort(getWebRequest(),
  +                        JdkConnectionHelper.getPort(getWebRequest(),
                               getConnection()),
  -                        HttpClientHelper.getPath(getWebRequest(),
  +                        JdkConnectionHelper.getPath(getWebRequest(),
                               getConnection()),
                           new Header(headerName, headerValue));
                   } catch (HttpException e) {
  
  
  
  1.6       +2 -2      jakarta-cactus/sample-servlet/src/unit/share/org/apache/cactus/unit/TestServletTestCase2.java
  
  Index: TestServletTestCase2.java
  ===================================================================
  RCS file: /home/cvs/jakarta-cactus/sample-servlet/src/unit/share/org/apache/cactus/unit/TestServletTestCase2.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- TestServletTestCase2.java	23 May 2002 13:20:38 -0000	1.5
  +++ TestServletTestCase2.java	23 Jul 2002 22:07:52 -0000	1.6
  @@ -261,7 +261,7 @@
           // Note: I am not sure how to retrieve multi valued headers. The
           // problem is that I use
           // URLConnection.setRequestProperty("testheader", "value1,value2") in
  -        // HttpClientHelper to send the headers but request.getHeaders() does
  +        // JdkConnectionHelper to send the headers but request.getHeaders() does
           // not seem to separate the different header values.
   
           // The RFC 2616 says :
  
  
  

--
To unsubscribe, e-mail:   <mailto:cactus-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:cactus-dev-help@jakarta.apache.org>


Mime
View raw message