jakarta-bsf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: BSF 3.0-beta3 release artifact review
Date Sun, 22 Mar 2009 18:53:54 GMT
On 22/03/2009, ant elder <antelder@apache.org> wrote:
> Many thanks for the review, comments in line. I've made these changes
>  in trunk, i'll wait a bit longer for further comments and then create
>  fresh artifacts.
>
>    ...ant
>
>
>  On Sun, Mar 22, 2009 at 1:22 AM, sebb <sebbaz@gmail.com> wrote:
>  > On 21/03/2009, ant elder <ant.elder@gmail.com> wrote:
>  >> Following the user list request [1] for a new release of BSF 3 to
>  >>  support the latest JRuby engine i've done an update and created the
>  >>  artifacts for a BSF 3.0-beta3 release. I've uploaded the artifacts to:
>  >>
>  >>  http://people.apache.org/~antelder/bsf/3.0-beta3-RC1/
>  >>
>  >>  and there's an SVN tag at:
>  >>
>  >>  https://svn.apache.org/repos/asf/jakarta/bsf/tags/bsf-3.0-beta3
>  >
>  > Notice says:
>  > Copyright (c) 2005 - 2007
>  > Should probably be 2009; also the product name is missing - should be
>  > on first line.
>
>
> Fixed
>
>
>  > Also, the POM says <inceptionYear>1999</inceptionYear>, so perhaps
>  > that should be 1999-2009
>  >
>
>
> Fixed
>
>
>  > Release Notes says:
>  > Apache BSF 3 Beta2 Release Notes
>  > [should be Beta 3]
>  >
>
>
> Fixed
>
>
>  > "This 3.0-beta3 release is a maintenance release updating to support
>  > for the latest releases
>  > of various script language engines."
>  >
>  > That does not read well.
>  >
>
>
> Changed to "...maintenance release update to support..."
>
>
>
>  > It would be helpful if the top-level BUILDING file stated the minimum
>  > Java version required (appears to be 1.4.2, according to
>  > /distribution/src/bin/README).
>  >
>
>
> Added a comment saying BSF requires Java 1.4.2 to build
>
>
>  > JUnit 3.8.2 would be a better choice for Java 1.4+
>
>
> Updated to use JUnit 3.8.2
>
>
>  >
>  > The jar files all seem to have NOTICE and LICENSE files, which is
>  > good, and the MANIFEST is good - except it would be nice to include
>  > the java source and target versions as well.
>
>
> Added X-Compile-Source-JDK and X-Compile-Target-JDK entries saying 1.4.2.
>
>
>  >
>  > Class ScriptEngineManager imports "sun.misc.Service" which means that
>  > the code is only likely to work on a Sun JVM.
>  >
>
>
> Changed to use javax.imageio.spi.ServiceRegistry.
>
>
>
>  > Build fails when using Java 1.4.2, because
>  >
>  > bsf-api\src\main\java\javax\script\SimpleScriptContext.java uses
>  > Integer.valueOf(int) which is Java 1.5+.
>  >
>
>
> Updated to use "Integer.valueOf(Integer.toString(int)))".

That is considerably less efficient than new Integer(int).

>
>  > Fails to download WS02 Rhino POM, so could not complete build.
>  >
>
>
> This is working ok for me and the repository is accessible at
>  http://dist.wso2.org/maven2 when i try now, maybe it was down when you
>  tried?
>

But Maven was actually trying:

http://www-lk.wso2.com/~thilina/repository

Perhaps that repo should be disabled or removed?

[It's in testing/e4x/pom.xml]

>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
>  For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org


Mime
View raw message