jakarta-bsf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (BSF-15) BSFManager use of logging
Date Tue, 20 May 2008 19:07:55 GMT

    [ https://issues.apache.org/jira/browse/BSF-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598401#action_12598401

Sebb commented on BSF-15:

Just had a look at BSFManager in trunk, and it creates a logger in the constructor.

Seems to me that it would make more sense to create the logger as a private static final field
that can then be used by static methods as well.

> BSFManager use of logging
> -------------------------
>                 Key: BSF-15
>                 URL: https://issues.apache.org/jira/browse/BSF-15
>             Project: BSF
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Minor
> BSFManager seems to be a bit inconsistent in the way that it uses logging.
> For example, in some places is uses println() to report errors, and others it uses log.debug(),
when it should probably use log.warn().
> Probably worth taking a general look at how logging is used throughout BSF.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org

View raw message