Return-Path: 
 <bsf-dev-return-846-apmail-jakarta-bsf-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-bsf-dev-archive@www.apache.org
Received: (qmail 71742 invoked from network); 2 Sep 2006 18:58:41 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 2 Sep 2006 18:58:41 -0000
Received: (qmail 18736 invoked by uid 500); 2 Sep 2006 18:58:40 -0000
Delivered-To: apmail-jakarta-bsf-dev-archive@jakarta.apache.org
Received: (qmail 18712 invoked by uid 500); 2 Sep 2006 18:58:40 -0000
Mailing-List: contact bsf-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:bsf-dev-unsubscribe@jakarta.apache.org>
List-Help: <mailto:bsf-dev-help@jakarta.apache.org>
List-Post: <mailto:bsf-dev@jakarta.apache.org>
List-Id: "Bean Scripting Framework developers" <bsf-dev.jakarta.apache.org>
Reply-To: "Bean Scripting Framework developers" <bsf-dev@jakarta.apache.org>
Delivered-To: mailing list bsf-dev@jakarta.apache.org
Received: (qmail 18701 invoked by uid 99); 2 Sep 2006 18:58:40 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Sep 2006 11:58:40 -0700
X-ASF-Spam-Status: No, hits=0.5 required=10.0
	tests=DNS_FROM_RFC_ABUSE,SPF_HELO_PASS
X-Spam-Check-By: apache.org
Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194)
    by apache.org (qpsmtpd/0.29) with SMTP; Sat, 02 Sep 2006 11:58:39 -0700
Received: (qmail 71705 invoked from network); 2 Sep 2006 18:58:17 -0000
Received: from localhost.hyperreal.org (HELO ?127.0.0.1?) (127.0.0.1)
  by localhost.hyperreal.org with SMTP; 2 Sep 2006 18:58:17 -0000
Message-ID: <44F9D432.2000806@gmail.com>
Date: Sat, 02 Sep 2006 18:57:54 +0000
From: Sanka Samaranayke <ssanka@gmail.com>
User-Agent: Mail/News 1.5 (X11/20060223)
MIME-Version: 1.0
To: Bean Scripting Framework developers <bsf-dev@jakarta.apache.org>
Subject: Re: [patch] slightly cleaner build.xml
References: <1157009554.5587.8.camel@linux-dev>
In-Reply-To: <1157009554.5587.8.camel@linux-dev>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Spam-Rating: localhost.hyperreal.org 1.6.2 0/1000/N
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Applied.

Thanks,
Sanka

Kev Jackson wrote:
> Hi,
>
> Here's a mildly cleaner build.xml for BSF.  We are looking at
> including arbitrary conditions on all tasks based on the fact that
> to clean up this build file further I'd like to be able to do:
>
> <echo message="bar" if="${foo}"/>
>
> And at the moment ant doesn't support this.
>
> Anyway, here's the patch.
>
> Kev
>
> ----------------------------------------------------------------------
>
>
> Index: .
> ===================================================================
>  --- .    (revision 438751) +++ .    (working copy) @@ -62,11 +62,9 @@
> <!--
> ===================================================================
> --> <patternset id="java.source.files"> <!-- Optionally includes
> engines based on dependencies being present --> -        <!-- FIXME:
> Exclude the first three, temporarily -->
>
> <include name="**/bsf/*.java" /> <include name="**/util/**/*.java"
> /> - <include name="**/jacl/**" if="jacl.present" /> <include
> name="**/javascript/**" if="rhino.present" /> <include
> name="**/jython/**" if="jython.present" /> @@ -179,7 +177,6 @@
> <antcall target="checkJython" /> <antcall target="checkNetRexx" />
> <antcall target="checkRhino" /> -        <!--<echo message="Warning:
> Rhino dependencies were not resolved." unless="rhino.present"/>-->
> <antcall target="checkXalan" /> <antcall target="checkJUnit" />
> </target> @@ -184,11 +181,6 @@ <antcall target="checkJUnit" />
> </target>
>
> - - - - - <!--
> ===================================================================
> --> <!-- Compiles the source directory
> --> <!--
> ===================================================================
> --> @@ -196,9 +188,11 @@ <mkdir dir="${build.dest}"/> <javac
> srcdir="${src.dir}" destdir="${build.dest}"
> debug="${project.debug}" deprecation="${project.deprecation}">
> <classpath> -                <fileset dir="lib"><include
> name="*.jar"/></fileset> +                <fileset dir="lib">
+                    <include
> name="*.jar"/> +                </fileset> </classpath> -           
<patternset
> refid="java.source.files"></patternset> +            <patternset
> refid="java.source.files"/> </javac> </target>
>
> @@ -252,11 +246,9 @@ <classpath refid="anakia.classpath" />
> </taskdef>
>
> -        <anakia basedir="${site.src}" destdir="${site.dest}/"
> extension=".html" style="./site.vsl"
> projectFile="${site.projectFile}" excludes="**/stylesheets/**
> faq.xml" includes="**/*.xml" lastModifiedCheck="true"
> templatePath="${templ.path}"
> velocityPropertiesFile="${velocity.props}"> -        </anakia> +       
<anakia
> basedir="${site.src}" destdir="${site.dest}/" extension=".html"
> style="./site.vsl" projectFile="${site.projectFile}"
> excludes="**/stylesheets/** faq.xml" includes="**/*.xml"
> lastModifiedCheck="true" templatePath="${templ.path}"
> velocityPropertiesFile="${velocity.props}"/>
>
> -        <anakia basedir="${site.src}" destdir="${site.dest}/"
> extension=".html" style="./faq.vsl"
> projectFile="${site.projectFile}" includes="faq.xml"
> lastModifiedCheck="true" templatePath="${templ.path}"
> velocityPropertiesFile="${velocity.props}"> -        </anakia> +       
<anakia
> basedir="${site.src}" destdir="${site.dest}/" extension=".html"
> style="./faq.vsl" projectFile="${site.projectFile}"
> includes="faq.xml" lastModifiedCheck="true"
> templatePath="${templ.path}"
> velocityPropertiesFile="${velocity.props}"/>
>
> <copy todir="${site.dest}/images" filtering="no"> <fileset
> dir="${site.src}/images">
>
>
> ----------------------------------------------------------------------
>
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org For
> additional commands, e-mail: bsf-dev-help@jakarta.apache.org


- --
Sanka Samaranayake
WSO2 Inc.
T:+94-77-3506382 F:+94-11-2424304

http://sankas.blogspot.com/
http://www.wso2.net/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (GNU/Linux)

iD8DBQFE+dQy/Hd0ETKdgNIRApeuAJ41WcC9/WbNpQgz1Wnc6gAFeirYTACfVkvv
fCqnqSGi93tuPw8P9/+iEkg=
=PX9P
-----END PGP SIGNATURE-----


---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org