Return-Path: Mailing-List: contact bsf-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list bsf-dev@jakarta.apache.org Received: (qmail 82771 invoked from network); 3 Jul 2003 15:46:31 -0000 Received: from out1.smtp.messagingengine.com (HELO mail.messagingengine.com) (66.111.4.25) by daedalus.apache.org with SMTP; 3 Jul 2003 15:46:31 -0000 Received: from mail.messagingengine.com (localhost [127.0.0.1]) by localhost.localdomain (Postfix) with ESMTP id 52A9F326 for ; Thu, 3 Jul 2003 11:45:16 -0400 (EDT) Received: from 127.0.0.1 ([127.0.0.1] helo=mail.messagingengine.com) by messagingengine.com with SMTP; Thu, 03 Jul 2003 11:45:16 -0400 X-Epoch: 1057247116 X-Sasl-enc: c4W9L4qPo1PLoUH0EXMJHg Received: from fastmail.fm (tc.telecomputing.no [213.203.17.243]) by www.fastmail.fm (Postfix) with ESMTP id A6F00213 for ; Thu, 3 Jul 2003 11:45:15 -0400 (EDT) Message-ID: <3F044FD6.60308@fastmail.fm> Date: Thu, 03 Jul 2003 17:46:30 +0200 From: Igor Bukanov User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030701 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Bean Scripting Framework developers Subject: Re: [GUMP] Build Failure - jakarta-bsf References: <20030703122838.38996.qmail@icarus.apache.org> <3F042853.30806@fastmail.fm> <20030703110908.C30422@critterling.garfield.home> In-Reply-To: <20030703110908.C30422@critterling.garfield.home> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Victor J. Orlikowski wrote: > On Thu, Jul 03, 2003 at 02:57:55PM +0200, Igor Bukanov wrote: > >>> [javac] /home/rubys/jakarta/jakarta-bsf/src/org/apache/bsf/engines/javascript/JavaScriptEngine.java:194: cannot resolve symbol >>> [javac] symbol : method unwrap () >>> [javac] location: class org.mozilla.javascript.WrappedException >>> [javac] t = (Throwable) ((WrappedException) t).unwrap(); >>> [javac] ^ >>> [javac] 1 error >>> >>>BUILD FAILED >>>/home/rubys/jakarta/jakarta-bsf/build.xml:248: Compile failed; see the compiler error output for details. >> >>That code should be >>t = ((WrappedException) t).getWrappedException(); >>and not >>t = (Throwable) ((WrappedException) t).unwrap(); >> >>But I will update Rhino with a deprecated version of the unwrap method >>which was removed since WrappedException does not implement the Wrapper >>interface any longer for implementation reasons. >> > > > Igor, > > Thanks for the clarification. > > How long do you expect that the deprecated API will be present? I > ask because we would like to maintain compatibility with older > versions of Rhino (at least 1.5 R3) without hacks (if possible). The method getWrappedException was always present in WrappedException, thus changing the code to use it instead of unwrap would be fully backfarwd and forward compatible while removing unnecessary cast. The unwrap would exist at least in the next public release. Regards, Igor