jakarta-bsf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Igor Bukanov <i...@fastmail.fm>
Subject Re: [GUMP] Build Failure - jakarta-bsf
Date Thu, 03 Jul 2003 15:46:30 GMT
Victor J. Orlikowski wrote:
> On Thu, Jul 03, 2003 at 02:57:55PM +0200, Igor Bukanov wrote:
> 
>>>    [javac] /home/rubys/jakarta/jakarta-bsf/src/org/apache/bsf/engines/javascript/JavaScriptEngine.java:194:
cannot resolve symbol
>>>    [javac] symbol  : method unwrap ()
>>>    [javac] location: class org.mozilla.javascript.WrappedException
>>>    [javac]             t = (Throwable) ((WrappedException) t).unwrap();
>>>    [javac]                             ^
>>>    [javac] 1 error
>>>
>>>BUILD FAILED
>>>/home/rubys/jakarta/jakarta-bsf/build.xml:248: Compile failed; see the compiler
error output for details.
>>
>>That code should be
>>t = ((WrappedException) t).getWrappedException();
>>and not
>>t = (Throwable) ((WrappedException) t).unwrap();
>>
>>But I will update Rhino with a deprecated version of the unwrap method 
>>which was removed since WrappedException does not implement the Wrapper 
>>interface any longer for implementation reasons.
>>
> 
> 
> Igor,
> 
> Thanks for the clarification.
> 
> How long do you expect that the deprecated API will be present? I
> ask because we would like to maintain compatibility with older
> versions of Rhino (at least 1.5 R3) without hacks (if possible).

The method getWrappedException was always present in WrappedException, 
thus changing the code to use it instead of unwrap would be fully 
backfarwd and forward compatible while removing unnecessary cast. The 
unwrap would exist at least in the next public release.

Regards, Igor


Mime
View raw message