jakarta-alexandria-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Ruby" <ru...@us.ibm.com>
Subject RE: [PATCH] W3C Candidate Recommendation 24 October 2000
Date Mon, 08 Jan 2001 12:47:43 GMT
Jeff Martin wrote:
>
> Sorted

Sorted?

It looks like my patch was incompletely applied, resulting in a build
failure.  Take a look at the following:

   http://oss.software.ibm.com/developerworks/opensource/jakarta/proto/alexandr
   ia.html

Here's the relevant portion of the patch which is still outstanding:

   --- src/java/org/apache/alexandria/AggregateTests.java    2000/10/20 15:25:55  1.1
   +++ src/java/org/apache/alexandria/AggregateTests.java    2001/01/07 01:07:54
   @@ -98,10 +98,10 @@
              time = suite.getTime().substring(0,suite.getTime().length()-4);
                    run=suite.getTestcaseCount();
                    try{
   -                    errors=Integer.parseInt(suite.getErrors());
   +                    errors=suite.getErrors();
                    }catch(Exception e){}
                    try{
   -                    failures=Integer.parseInt(suite.getFailures());
   +                    failures=suite.getFailures();
                    }catch(Exception e){}
                    tests.addTestsuite(suite);
                }

Further background: there were a number of places where the code generated
by the schema differed from what was produced previously.  The rule I tried
to apply was to make the change which was less disruptive to the code.  In
these two cases only, I saw an opportunity to simplify the code to match
the new schema produced.

- Sam Ruby


Mime
View raw message