Mailing-List: contact users-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@jackrabbit.apache.org
Received-SPF: pass (athena.apache.org: domain of willscheidegger@mac.com
 designates 17.158.233.227 as permitted sender)
MIME-version: 1.0
Content-type: text/plain; charset=windows-1252
Subject: Re: Work on Jackrabbit OCM
From: Will Scheidegger <willscheidegger@mac.com>
In-reply-to: 
 <CABXgNGnCqf7NP8RtFTeCxmQCohmBdj43hxmSQaeGbPKE2x-DQA@mail.gmail.com>
Date: Thu, 24 May 2012 11:34:03 +0200
Content-transfer-encoding: quoted-printable
Message-id: <5E9A5D5E-6B9F-4516-9165-8BDDA72AA42D@mac.com>
References: 
 <CABXgNGnCqf7NP8RtFTeCxmQCohmBdj43hxmSQaeGbPKE2x-DQA@mail.gmail.com>
To: users@jackrabbit.apache.org

Hi Ard

This is only very vaguely related to what you are doing,=85 but since =
you seem to have commit rights on OCM and you will be working on it:

A long time ago I discussed a bug in the DefaultCollectionConverterImpl =
class [1]. It seems like this bug still exists today [2]. I'm not sure, =
but I think I provided a patch back then. In any case, the patch would =
be:

--- Base (BASE)
+++ Locally Modified (Based On LOCAL)
@@ -111,7 +111,7 @@
                     + collectionDescriptor.getFieldName() + " for the =
classdescriptor : " + =
collectionDescriptor.getClassDescriptor().getClassName());
         }
=20
-        Node collectionNode =3D parentNode.addNode(jcrName);
+        Node collectionNode =3D parentNode.addNode(jcrName, =
collectionDescriptor.getJcrType());
=20
         ClassDescriptor elementClassDescriptor =3D =
mapper.getClassDescriptorByClass( =
ReflectionUtils.forName(collectionDescriptor.getElementClassName()));
=20


Best regards,
will


[1] =
http://www.apacheserver.net/OCM-1-6-CollectionDescriptor-getJcrType-at1960=
70.htm
[2] =
https://svn.apache.org/repos/asf/jackrabbit/commons/ocm/trunk/src/main/jav=
a/org/apache/jackrabbit/ocm/manager/collectionconverter/impl/DefaultCollec=
tionConverterImpl.java


On 23.05.2012, at 17:34, Ard Schrijvers wrote:

> Hello,
>=20
> I will be working on Jackrabbit ocm [1] the coming weeks. Currently,
> there are no branches nor tags since it has been moved to jackrabbit
> commons. I also noticed that it does compile against jackrabbit core
> 2.4.1, however it has some test failures. All tests run fine until jr
> core 2.2.9
>=20
> I'll fix the code / unit tests to align it with 2.4.1, but will also
> pick up other work/tasks (like trying to avoid slow queries) : We are
> planning to integrate it into rave [1] as an optional persistence
> layer to store for example page definitions
>=20
> If there are developers would like me to first branch the current
> trunk against jackrabbit core 2.2.9, please let me know. Any other
> feedback is also more than welcome.
>=20
> Regards Ard
>=20
> [1] https://svn.apache.org/repos/asf/jackrabbit/commons/ocm/trunk/
> [2] http://rave.apache.org/
>=20
> --=20
> Amsterdam - Oosteinde 11, 1017 WT Amsterdam
> Boston - 1 Broadway, Cambridge, MA 02142
>=20
> US +1 877 414 4776 (toll free)
> Europe +31(0)20 522 4466
> www.onehippo.com