From users-return-11667-apmail-jackrabbit-users-archive=jackrabbit.apache.org@jackrabbit.apache.org Fri Jun 19 08:27:51 2009 Return-Path: Delivered-To: apmail-jackrabbit-users-archive@minotaur.apache.org Received: (qmail 49512 invoked from network); 19 Jun 2009 08:27:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 19 Jun 2009 08:27:50 -0000 Received: (qmail 72702 invoked by uid 500); 19 Jun 2009 08:28:01 -0000 Delivered-To: apmail-jackrabbit-users-archive@jackrabbit.apache.org Received: (qmail 72682 invoked by uid 500); 19 Jun 2009 08:28:01 -0000 Mailing-List: contact users-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: users@jackrabbit.apache.org Delivered-To: mailing list users@jackrabbit.apache.org Received: (qmail 72671 invoked by uid 99); 19 Jun 2009 08:28:01 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jun 2009 08:28:01 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of mreutegg@day.com designates 207.126.148.183 as permitted sender) Received: from [207.126.148.183] (HELO eu3sys201aog003.obsmtp.com) (207.126.148.183) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 19 Jun 2009 08:27:50 +0000 Received: from source ([209.85.218.206]) by eu3sys201aob003.postini.com ([207.126.154.11]) with SMTP ID DSNKSjtL8o+hkESnxxe5op+fmT+GXEh7EK7d@postini.com; Fri, 19 Jun 2009 08:27:30 UTC Received: by bwz2 with SMTP id 2so1828828bwz.14 for ; Fri, 19 Jun 2009 01:27:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.126.69 with SMTP id b5mr1956178fas.107.1245400049908; Fri, 19 Jun 2009 01:27:29 -0700 (PDT) In-Reply-To: <75c3a4170906170216i1df7a903x352f0db6dd360444@mail.gmail.com> References: <75c3a4170906170216i1df7a903x352f0db6dd360444@mail.gmail.com> Date: Fri, 19 Jun 2009 10:27:29 +0200 Message-ID: Subject: Re: jackrabbit-jcr-tests questions From: Marcel Reutegger To: users@jackrabbit.apache.org Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org Hi Sergey, On Wed, Jun 17, 2009 at 11:16, Sergey Kabashnyuk wrote: > 1. In tests > =A0 org.apache.jackrabbit.test.api.query.qom.QueryObjectModelFactoryTest#= testColumn > =A0 org.apache.jackrabbit.test.api.query.qom.QueryObjectModelFactoryTest#= testCreateQueryWithConstraintOrderingAndColumn > =A0 org.apache.jackrabbit.test.api.query.qom.QueryObjectModelFactoryTest#= testCreateQueryFromSourceWithConstraintOrderingAndColumn > > Used construction > Column col =3D qf.column(SELECTOR_NAME1, propertyName1, null); > > But by the specification 6.7.39 Column > If propertyName is specified, columnName is REQUIRED and used to name the > =A0column in the tabular results. > > Is this a correct use of Column construction? no, I think that is/was wrong. I fixed those test cases yesterday. > 2. Test org.apache.jackrabbit.test.api.NodeCanAddMixinTest#testAddMixinTw= ice > Have one interesting line =93adding again (mixin) must succeed=94. Is it > implementation > specification or it's come from the specification? not sure about this one. this test was added for JCR 2.0. I'll have to chec= k... > 3.org.apache.jackrabbit.test.api.query.qom.OrderingTest#testMultipleSelec= tors > As I understand the test logic is based on the sorting of values of > RIGHT selector. > But in the results of RIGHT selector contains two same nodes, node =93n2= =94. > So the sorting order is not clear. May be it means the sorting by > LEFT selector. Because the results of LEFT selectors contains > two nodes =93n1=94 , =93n2=94 which exactly match in expected results? your are right. I've just fixed that and committed the change. Thanks a lot for reporting those issues. regards marcel > Thanks. > > Sergey Kabashnyuk > eXo Platform SAS >