jackrabbit-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcel Reutegger <marcel.reuteg...@day.com>
Subject Re: jackrabbit-jcr-tests questions
Date Fri, 19 Jun 2009 08:27:29 GMT
Hi Sergey,

On Wed, Jun 17, 2009 at 11:16, Sergey Kabashnyuk<ksmmlist@gmail.com> wrote:
> 1. In tests
>   org.apache.jackrabbit.test.api.query.qom.QueryObjectModelFactoryTest#testColumn
>   org.apache.jackrabbit.test.api.query.qom.QueryObjectModelFactoryTest#testCreateQueryWithConstraintOrderingAndColumn
>   org.apache.jackrabbit.test.api.query.qom.QueryObjectModelFactoryTest#testCreateQueryFromSourceWithConstraintOrderingAndColumn
>
> Used construction
> Column col = qf.column(SELECTOR_NAME1, propertyName1, null);
>
> But by the specification 6.7.39 Column
> If propertyName is specified, columnName is REQUIRED and used to name the
>  column in the tabular results.
>
> Is this a correct use of Column construction?

no, I think that is/was wrong. I fixed those test cases yesterday.

> 2. Test org.apache.jackrabbit.test.api.NodeCanAddMixinTest#testAddMixinTwice
> Have one interesting line “adding again (mixin) must succeed”. Is it
> implementation
> specification or it's come from the specification?

not sure about this one. this test was added for JCR 2.0. I'll have to check...

> 3.org.apache.jackrabbit.test.api.query.qom.OrderingTest#testMultipleSelectors
> As I understand the test logic is based on the sorting of values of
> RIGHT selector.
> But in the results of RIGHT selector contains two same nodes, node “n2”.
> So the sorting order is not clear. May be it means the sorting by
> LEFT selector. Because the results of LEFT selectors contains
> two nodes “n1” , “n2” which exactly match in expected results?

your are right. I've just fixed that and committed the change.

Thanks a lot for reporting those issues.

regards
 marcel

> Thanks.
>
> Sergey Kabashnyuk
> eXo Platform SAS
>

Mime
View raw message