jackrabbit-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Roman Puchkovskiy <roman.puchkovs...@blandware.com>
Subject JCAConnectionRequestInfo: equals() and hashCode() are inconsistent?
Date Mon, 30 Jun 2008 11:31:59 GMT

Looking at JCAConnectionRequestInfo, I see that in its equals() method it
handles the comparison of SimpleCredentials as a special case.
SimpleCredentials does not override equals() method, so
JCAConnectionRequestInfo.equals() makes the comparison by hand.
But hashCode() method just delegates to Credentials' hashCode() method which
is not overridden in SimpleCredentials too. So, when you place a
JCAConnectionRequestInfo in the HashSet (or into a HashMap as a key) you
will never see hits.
This, in particular, seems to break JCR session pooling.
Is this just a bug, or there's some rationale behind such inconsistency?

Thanks in advance.
View this message in context: http://www.nabble.com/JCAConnectionRequestInfo%3A-equals%28%29-and-hashCode%28%29-are-inconsistent--tp18193632p18193632.html
Sent from the Jackrabbit - Users mailing list archive at Nabble.com.

View raw message