jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konrad Windszus (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OAK-9047) Make the DefaultAuthorizableActionProvider require a configuration
Date Mon, 04 May 2020 14:37:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098986#comment-17098986
] 

Konrad Windszus commented on OAK-9047:
--------------------------------------

Without authorizable actions at least the service https://github.com/apache/jackrabbit-oak/blob/1f90e8c632868e658cc60b95bc5ec49182c4e173/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/user/action/DefaultAuthorizableActionProvider.java#L106
is useless (except for not preventing the {{SecurityProviderRegistration}} to start). Instead
the cleaner approach would be that in such setups the service is not required in the first
place (in https://github.com/apache/jackrabbit-oak/blob/f454d227ad7418b1c7f911c67e5aead2208fdb5e/oak-core/src/main/java/org/apache/jackrabbit/oak/security/internal/SecurityProviderRegistration.java#L125).

> Make the DefaultAuthorizableActionProvider require a configuration
> ------------------------------------------------------------------
>
>                 Key: OAK-9047
>                 URL: https://issues.apache.org/jira/browse/OAK-9047
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: security-spi
>            Reporter: Konrad Windszus
>            Priority: Major
>
> Currently configuring the {{DefaultAuthorizableActionProvider}} leads to restart of the
Oak repository in the context of https://issues.apache.org/jira/browse/SLING-7811?focusedCommentId=16573171&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16573171.

> It would make sense to only start the service https://github.com/apache/jackrabbit-oak/blob/1f90e8c632868e658cc60b95bc5ec49182c4e173/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/user/action/DefaultAuthorizableActionProvider.java#L45
once a mandatory configuration is in place.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message