jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-9024) oak-solr-osgi imports org.slf4j.impl
Date Fri, 08 May 2020 09:46:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-9024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096360#comment-17096360
] 

Julian Reschke edited comment on OAK-9024 at 5/8/20, 9:45 AM:
--------------------------------------------------------------

bndtools may have the answer, in particular the [xref command|https://bnd.bndtools.org/commands/xref.html]
 The following is an excerpt from its output, indicating which classes use (i.e. import on
a java level) classes from {{org.slf4j.impl}}.

{noformat}
$ bnd xref -cf target/oak-solr-osgi-1.27-SNAPSHOT.jar
        ...
        org.slf4j.impl.StaticLoggerBinder < org.apache.solr.logging.LogWatcher
                                            org.apache.solr.servlet.StartupLoggingUtils
        ...
{noformat}

Removing these two classes from the {{Embed-Dependency}} instruction should remove the import
for {{org.slf4j.impl}}. However, it would still be required to analyze where the Oak code
(transitively) depends on these classes and examine if it can be safely used without them.
If removing these classes is not an option, it may still be safe to exclude the import for
{{org.slf4j.impl}} explicitly, iff no code path is used, where the {{StaticLoggerBinder}}
is used. If it _is_ used, however, then it we really need {{StaticLoggerBinder}} on the class
path (or provide an upstream fix for Solr).


was (Author: jsedding):
bndtools may have the answer, in particular the [xref command|https://bnd.bndtools.org/commands/xref.html]
 The following is an excerpt from its output, indicating which classes use (i.e. import on
a java level) classes from {{org.slf4j.impl}}.

{noformat}
$ bnd xref -cf target/oak-solr-osgi-1.27-SNAPSHOT.jar
        ...
        org.slf4j.impl.StaticLoggerBinder < org.apache.solr.logging.LogWatcher
                                            org.apache.solr.servlet.StartupLoggingUtils
        ...
{noformat}

Removing these two classes from the {{Embed-Dependency}} instruction should remove the import
for {{org.slf4j.impl}}. However, it woudl still be required to analyze where the Oak code
(transitively) depends on these classes and examine if it can be safely used without them.
If removing these classes is not an option, it may still be safe to exclude the import for
{{org.slf4j.impl}} explicitly, iff no code path is used, where the {{StaticLoggerBinder}}
is used. If it _is_ used, however, then it we really need {{StaticLoggerBinder}} on the class
path (or provide an upstream fix for Solr).

> oak-solr-osgi imports org.slf4j.impl
> ------------------------------------
>
>                 Key: OAK-9024
>                 URL: https://issues.apache.org/jira/browse/OAK-9024
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: solr
>            Reporter: Julian Reschke
>            Assignee: Manfred Baedke
>            Priority: Minor
>             Fix For: 1.28.0
>
>         Attachments: OAK-9024.patch
>
>
> From the manifest:
> {{org.slf4j.impl;version="[1.6,2)"}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message