jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Sedding (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OAK-9024) oak-solr-osgi imports org.slf4j.impl
Date Wed, 06 May 2020 07:54:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-9024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100554#comment-17100554
] 

Julian Sedding commented on OAK-9024:
-------------------------------------

[~baedke] I performed a simple test. In the pom of the oak-solr-osgi module I prevent the
zookeeper dependency from being embedded by changing the dependency scope to "provided". Then
I created a diff of the Import-Package statement of the oak-solr-osgi bundle before and after
this change.

{noformat}
14d13
<   com.ibm.security.krb5.internal         {resolution:=optional}
42,44d40
<   javax.security.auth                    
<   javax.security.auth.callback           
<   javax.security.auth.kerberos           
46d41
<   javax.security.auth.spi                
48d42
<   javax.security.sasl                    
135d128
<   org.apache.log4j.jmx                   {resolution:=optional, version=[1.2,2)}
156a150,154
>   org.apache.zookeeper                   {version=[3.4,4)}
>   org.apache.zookeeper.data              {version=[3.4,4)}
>   org.apache.zookeeper.server            {version=[3.4,4)}
>   org.apache.zookeeper.server.auth       {version=[3.4,4)}
>   org.apache.zookeeper.server.quorum     {version=[3.4,4)}
166,170d163
<   org.jboss.netty.bootstrap              {resolution:=optional, version=[3.7,4)}
<   org.jboss.netty.buffer                 {resolution:=optional, version=[3.7,4)}
<   org.jboss.netty.channel                {resolution:=optional, version=[3.7,4)}
<   org.jboss.netty.channel.group          {resolution:=optional, version=[3.7,4)}
<   org.jboss.netty.channel.socket.nio     {resolution:=optional, version=[3.7,4)}
187d179
<   sun.security.krb5                      {resolution:=optional}
{noformat}

As you can see the zookeeper packages are now imported (because they are not provided within
the bundle), and some other packages that are only used by zookeeper are no longer imported.
If zookeeper with its org.slf4j.slf4j-log4j12 dependency was the cause for {{org.slf4j.impl}}
to be imported, then we would expect it to disappear when zookeeper is no longer embedded.

This is not the case, ergo zookeeper is not the root cause you're looking for. As I outlined
before, the root cause is Solr itself.

> Note that IIUC embedding dependencies of oak-solr-core is one of the points of oak-solr-osgi.

I don't think embedding a logging binding was ever the goal of oak-solr-osgi. If you are interested
in the original reasoning why this bundle was created, the discussion https://markmail.org/thread/5xsyx5l4c6euqtt2
may be interesting.

> oak-solr-osgi imports org.slf4j.impl
> ------------------------------------
>
>                 Key: OAK-9024
>                 URL: https://issues.apache.org/jira/browse/OAK-9024
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: solr
>            Reporter: Julian Reschke
>            Assignee: Manfred Baedke
>            Priority: Minor
>             Fix For: 1.28.0
>
>         Attachments: OAK-9024.patch
>
>
> From the manifest:
> {{org.slf4j.impl;version="[1.6,2)"}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message