From oak-issues-return-73372-archive-asf-public=cust-asf.ponee.io@jackrabbit.apache.org Tue Jul 9 12:40:01 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9276018062B for ; Tue, 9 Jul 2019 14:40:01 +0200 (CEST) Received: (qmail 32178 invoked by uid 500); 9 Jul 2019 12:40:01 -0000 Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-issues@jackrabbit.apache.org Received: (qmail 32161 invoked by uid 99); 9 Jul 2019 12:40:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jul 2019 12:40:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5B7E7E0782 for ; Tue, 9 Jul 2019 12:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 11A1D26569 for ; Tue, 9 Jul 2019 12:40:00 +0000 (UTC) Date: Tue, 9 Jul 2019 12:40:00 +0000 (UTC) From: "Julian Reschke (JIRA)" To: oak-issues@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OAK-8448) VersionGC may get stuck at 60s scope MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OAK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881193#comment-16881193 ] Julian Reschke commented on OAK-8448: ------------------------------------- trunk: [r1862806|http://svn.apache.org/r1862806] [r1862537|http://svn.apache.org/r1862537] > VersionGC may get stuck at 60s scope > ------------------------------------- > > Key: OAK-8448 > URL: https://issues.apache.org/jira/browse/OAK-8448 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk > Affects Versions: 1.8.9 > Reporter: Julian Reschke > Assignee: Julian Reschke > Priority: Major > Labels: candidate_oak_1_10 > Fix For: 1.16.0 > > Attachments: OAK-8448.diff, test.diff > > > It seems that if the VersionGarbageCollector reduces the scope to a 60s interval, it'll never change it back to a bigger interval. This is because the collectLimit gets set to 0: > {noformat} > if (scope.getDurationMs() <= options.precisionMs) { > // If we have narrowed the collect time interval down as much as we can, no > // longer enforce a limit. We need to get through this. > collectLimit = 0; > log.debug("time interval <= precision ({} ms), disabling collection limits", options.precisionMs); > } > {noformat} > ...and later on this is interpreted as "there were no restrictions in the prior run that need to be updated": > {noformat} > if (maxCollect <= 0) { > log.debug("successful run without effective limit, keeping recommendations"); > } > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)