jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-8328) Bug in index definition can block indexing / cause indexing in a loop
Date Fri, 14 Jun 2019 14:04:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864099#comment-16864099
] 

Thomas Mueller commented on OAK-8328:
-------------------------------------

Thanks [~nitigup]! I added my own OAK-8328_3.patch with a few changes:

* The added "try { ... } catch" requires adding spaces unfortunately, so a formatting change.
I don't know how this could have been avoided.
* I had to merge the test changes manually (not your fault), and I didn't use static imports
as much... I think it's a matter of taste, your patch was just fine. I hope you don't mind.

I'll not commit the changes right now, as it would break the build. Plus we want to investigate
some broken upstream problem. 

> This fixes the failing test .

Yes it does.


> Bug in index definition can block indexing / cause indexing in a loop
> ---------------------------------------------------------------------
>
>                 Key: OAK-8328
>                 URL: https://issues.apache.org/jira/browse/OAK-8328
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, lucene
>            Reporter: Nitin Gupta
>            Assignee: Thomas Mueller
>            Priority: Major
>              Labels: indexingPatch
>         Attachments: OAK-8328.patch, OAK-8328_2.patch
>
>
> If we  set "/oak:index/indexName/entryCount" to a Long multi-valued property. That will
cause the system to reindex in a loop... You only see the root cause if debug level logging
is enabled. There are likely other such problems. Oak should log a proper meaningful exception
for config errors, and if possible not get into this loop. It also blocks other indexes to
be updated I think.
>  
>  
> {code:java}
> 29.03.2019 11:58:55.688 *INFO* [async-index-update-async] org.apache.jackrabbit.oak.plugins.index.IndexUpdate
Reindexing will be performed for following indexes: [/oak:index/unifiedCreatedLucene]
> 29.03.2019 11:59:00.691 *INFO* [async-index-update-async] org.apache.jackrabbit.oak.plugins.index.IndexUpdate
Reindexing will be performed for following indexes: [/oak:index/unifiedCreatedLucene]
> 29.03.2019 11:59:05.685 *INFO* [async-index-update-async] org.apache.jackrabbit.oak.plugins.index.IndexUpdate
Reindexing will be performed for following indexes: [/oak:index/unifiedCreatedLucene]
> 29.03.2019 11:59:10.687 *INFO* [async-index-update-async] org.apache.jackrabbit.oak.plugins.index.IndexUpdate
Reindexing will be performed for following indexes: [/oak:index/unifiedCreatedLucene]
> 29.03.2019 11:59:15.685 *INFO* [async-index-update-async] org.apache.jackrabbit.oak.plugins.index.IndexUpdate
Reindexing will be performed for following indexes: [/oak:index/unifiedCreatedLucene]
> 29.03.2019 11:59:20.688 *INFO* [async-index-update-async] org.apache.jackrabbit.oak.plugins.index.IndexUpdate
Reindexing will be performed for following indexes: [/oak:index/unifiedCreatedLucene]
> 29.03.2019 12:13:50.692 *DEBUG* [async-index-update-async] org.apache.jackrabbit.oak.plugins.index.AsyncIndexUpdate
[async] The index update is still failing
> java.lang.IllegalStateException: null
> 	at com.google.common.base.Preconditions.checkState(Preconditions.java:134)
> 	at org.apache.jackrabbit.oak.segment.SegmentPropertyState.getValue(SegmentPropertyState.java:145)
> 	at org.apache.jackrabbit.oak.plugins.index.lucene.IndexDefinition.<init>(IndexDefinition.java:358)
> 	at org.apache.jackrabbit.oak.plugins.index.lucene.IndexDefinition.<init>(IndexDefinition.java:95)
> 	at org.apache.jackrabbit.oak.plugins.index.lucene.IndexDefinition$Builder.build(IndexDefinition.java:314)
> 	at org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexEditorContext.enableReindexMode(LuceneIndexEditorContext.java:184)
> 	at org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexEditor.enter(LuceneIndexEditor.java:118)
> 	at org.apache.jackrabbit.oak.spi.commit.ProgressNotificationEditor.enter(ProgressNotificationEditor.java:71)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message