jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Davide Giannella (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OAK-6919) SegmentCache might introduce unwanted memory references to SegmentId instances
Date Tue, 04 Jun 2019 15:34:06 GMT

     [ https://issues.apache.org/jira/browse/OAK-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Davide Giannella updated OAK-6919:
----------------------------------
    Fix Version/s: 1.16.0

> SegmentCache might introduce unwanted memory references to SegmentId instances
> ------------------------------------------------------------------------------
>
>                 Key: OAK-6919
>                 URL: https://issues.apache.org/jira/browse/OAK-6919
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>            Priority: Major
>             Fix For: 1.14.0, 1.16.0
>
>
> {{SegmentCache}} contains, through the underlying Guava cache, hard references to both
{{SegmentId}} and {{Segment}} instances. Thus, {{SegmentCache}} contributes to the computation
of in-memory references that, in turn, constitute the root references of the garbage collection
algorithm.
> Further investigations are needed to assess this statement but, if {{SegmentCache}} is
proved to be problematic, there are some possible solutions.
> For example, {{SegmentCache}} might be reworked to store references to MSB/LSB pairs
as keys, instead of to {{SegmentId}} instances. Moreover, instead of referencing {{Segment}}
instances as values, {{SegmentCache}} might hold references to their underlying {{ByteBuffer}}.
With these changes in place, {{SegmentCache}} would not interfere with {{SegmentTracker}}
and the garbage collection algorithm.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message