From oak-issues-return-70903-archive-asf-public=cust-asf.ponee.io@jackrabbit.apache.org Wed Apr 24 12:41:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 222B518076D for ; Wed, 24 Apr 2019 14:41:02 +0200 (CEST) Received: (qmail 28778 invoked by uid 500); 24 Apr 2019 12:41:01 -0000 Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-issues@jackrabbit.apache.org Received: (qmail 28639 invoked by uid 99); 24 Apr 2019 12:41:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Apr 2019 12:41:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C1A33E2AD1 for ; Wed, 24 Apr 2019 12:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 69AE325812 for ; Wed, 24 Apr 2019 12:41:00 +0000 (UTC) Date: Wed, 24 Apr 2019 12:41:00 +0000 (UTC) From: "angela (JIRA)" To: oak-issues@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (OAK-8270) Add variant of PermissionUtil.getReadOnlyTree that never returns null MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OAK-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8270. ------------------------- Resolution: Fixed Fix Version/s: 1.14.0 Committed revision 1858042. > Add variant of PermissionUtil.getReadOnlyTree that never returns null > --------------------------------------------------------------------- > > Key: OAK-8270 > URL: https://issues.apache.org/jira/browse/OAK-8270 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, security > Reporter: angela > Assignee: angela > Priority: Major > Fix For: 1.14.0 > > Attachments: OAK-8270.patch > > > the current implementation of {{PermissionUtil.getReadOnlyTree}} may have a null tree passed and will in this case return {{null}}, which is not suited for those parts of the permission evaluation where the {{Tree}} cannot be null and a non-null return-value is therefore expected. > [~stillalex], i would therefore suggest to rename the existing method to {{getReadOnlyTreeOrNull}} and add a variant that never returns null. see attached patch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)