From oak-issues-return-70551-archive-asf-public=cust-asf.ponee.io@jackrabbit.apache.org Mon Apr 15 09:01:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EE9F918064C for ; Mon, 15 Apr 2019 11:01:11 +0200 (CEST) Received: (qmail 82470 invoked by uid 500); 15 Apr 2019 09:01:11 -0000 Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-issues@jackrabbit.apache.org Received: (qmail 82459 invoked by uid 99); 15 Apr 2019 09:01:11 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Apr 2019 09:01:11 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E52F5E2AC7 for ; Mon, 15 Apr 2019 09:01:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 525EA245A4 for ; Mon, 15 Apr 2019 09:01:00 +0000 (UTC) Date: Mon, 15 Apr 2019 09:01:00 +0000 (UTC) From: "angela (JIRA)" To: oak-issues@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OAK-8234) Reduce object allocation in PermissionProviderImpl for admin sessions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OAK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817666#comment-16817666 ] angela commented on OAK-8234: ----------------------------- [~stillalex], while the intended change makes a lot of sense to me, i don't particularly like the delegatee approach with yet another redirection. in particular since it creates a lot of changes to the {{PermissionProviderImpl}} that might result in subtle regressions. Is there a reason for not making the distinction between administrative subjects and regular subjects right in the {{AuthorizationConfigurationImpl}}? that would place that fundamental difference between set of principals that are subjected to permission evaluation vs those that are not prominently in the flow. also for administrative principals the whole {{Mount}} handling is IMO redundant and which is not taken into account in the patch as far as i saw. wdyt? > Reduce object allocation in PermissionProviderImpl for admin sessions > --------------------------------------------------------------------- > > Key: OAK-8234 > URL: https://issues.apache.org/jira/browse/OAK-8234 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, security > Reporter: Alex Deparvu > Assignee: Alex Deparvu > Priority: Major > > There was already a lot of work done here to improve efficiency of admin sessions, but we can still do better by simply not creating many of the objects needed as parameters for the {{CompiledPermissions}} which will be ignored anyway in the case of admin sessions. > Ex: There are a lot of immutable trees (created via {{PermissionUtil.getReadOnlyTree(tree, immutableRoot)}}) that are not used for the evaluation. > Thanks to [~mreutegg] for spotting this one! -- This message was sent by Atlassian JIRA (v7.6.3#76005)