From oak-issues-return-70372-archive-asf-public=cust-asf.ponee.io@jackrabbit.apache.org Wed Apr 10 11:15:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9B482180626 for ; Wed, 10 Apr 2019 13:15:04 +0200 (CEST) Received: (qmail 40653 invoked by uid 500); 10 Apr 2019 11:15:02 -0000 Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-issues@jackrabbit.apache.org Received: (qmail 40547 invoked by uid 99); 10 Apr 2019 11:15:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Apr 2019 11:15:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BB21FE2A7F for ; Wed, 10 Apr 2019 11:15:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6CBCC2459F for ; Wed, 10 Apr 2019 11:15:00 +0000 (UTC) Date: Wed, 10 Apr 2019 11:15:00 +0000 (UTC) From: "Marcel Reutegger (JIRA)" To: oak-issues@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (OAK-8141) Replace String path with custom data type MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OAK-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved OAK-8141. ----------------------------------- Resolution: Fixed > Replace String path with custom data type > ----------------------------------------- > > Key: OAK-8141 > URL: https://issues.apache.org/jira/browse/OAK-8141 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk > Reporter: Marcel Reutegger > Assignee: Marcel Reutegger > Priority: Major > Fix For: 1.14.0 > > Attachments: OAK-8141.patch, OAK-8141.patch > > > DocumentNodeState objects and other related data is currently identified with a String path in the various caches in the DocumentNodeStore. Read benchmarks like GetDeepNodeTest that only read data from memory are significantly slower on a DocumentNodeStore compared to a SegmentNodeStore. In these kind of tests the DocumentNodeStore is usually busy with String operations like constructing the path for a child node or calculating the hash code for a lookup in a cache. > This issue is about a potential improvement that replaces the use of a plain String for the path of a DocumentNodeState and use a custom Path type instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)