jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-8234) Reduce object allocation in PermissionProviderImpl for admin sessions
Date Mon, 15 Apr 2019 11:31:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817877#comment-16817877

angela commented on OAK-8234:

[~stillalex], the patch for {{AuthorizationConfigurationImpl}} looks good to me. i still think
it's wrong to ignore the test case that fails. in fact the test class that contains the failing
test is called {{PermissionProviderImplTest}} but apparently it doesn't test {{PermissionProviderImpl}}
but the {{AllPermissionProviderImpl}}. So quite obviously it doesn't test the class it claims
to test.... adjusting the {{createPermissionProviderImpl}} method should do the trick... maybe
creating {{PermissionProviderImpl}} instance manually instead of letting the configuration
create it?
Also: I would like the new class {{AllPermissionProviderImpl}} to come with a dedicated test
class with unit tests. Also an extra test for {{AuthorizationConfigurationImpl}}...

> Reduce object allocation in PermissionProviderImpl for admin sessions
> ---------------------------------------------------------------------
>                 Key: OAK-8234
>                 URL: https://issues.apache.org/jira/browse/OAK-8234
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>            Priority: Major
> There was already a lot of work done here to improve efficiency of admin sessions, but
we can still do better by simply not creating many of the objects needed as parameters for
the {{CompiledPermissions}} which will be ignored anyway in the case of admin sessions.
> Ex: There are a lot of immutable trees (created via {{PermissionUtil.getReadOnlyTree(tree,
immutableRoot)}}) that are not used for the evaluation.
> Thanks to [~mreutegg] for spotting this one!

This message was sent by Atlassian JIRA

View raw message