jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-8209) Improve Node.isNodeType(String) performance
Date Wed, 10 Apr 2019 10:55:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814325#comment-16814325
] 

Alex Deparvu edited comment on OAK-8209 at 4/10/19 10:54 AM:
-------------------------------------------------------------

bq. The root in SessionDelegate is final. That is, the ReadWriteNodeTypeManager can just as
well remember the Tree.
I think this is not entirely correct. The delegate can call Root#rebase (or Root#refresh)
which can invalidate the tree:
{noformat}
Rebase this root instance to the latest revision. After a call to this method, trees obtained
through getTree(String) may become non existing.
{noformat}

I think you could work around this by setting it to null in {{refresh()}}.


was (Author: alex.parvulescu):
bq. The root in SessionDelegate is final. That is, the ReadWriteNodeTypeManager can just as
well remember the Tree.
I think this is not entirely correct. The delegate can call Root#rebase which can invalidate
the tree:
{noformat}
Rebase this root instance to the latest revision. After a call to this method, trees obtained
through getTree(String) may become non existing.{noformat}
I think you could work around this by setting it to null in {{refresh()}}.

> Improve Node.isNodeType(String) performance
> -------------------------------------------
>
>                 Key: OAK-8209
>                 URL: https://issues.apache.org/jira/browse/OAK-8209
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>            Priority: Minor
>
> Profiling an application running on Oak showed calls to {{Node.isNodeType(String)}} as
one of the hot spots. While it may be possible to reduce those calls there's probably also
some potential in optimizing the implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message