jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitin Gupta (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-8035) Debug logging when two or more indices have same or very close cost amounts doesn't work in case both indices belong to the same type of Query Index
Date Tue, 19 Feb 2019 12:04:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771857#comment-16771857
] 

Nitin Gupta edited comment on OAK-8035 at 2/19/19 12:03 PM:
------------------------------------------------------------

[~reschke] - agreed - will keep this in mind in future .
{noformat}
No, adding new test dependencies is fine. We just should do it consciously and coordinated.
My preference would be not to add new dependencies just because somebody liked a particular
library. In the end, the whole team needs to be able to support the code in the future{noformat}
 

I was just about to add this patch here [^OAK-8035_4.patch]  for the changes as per your
suggestions - but you beat me to it . Thanks for the help :)


was (Author: nitigup):
[~reschke] - agreed . 

I was just about to add this patch here [^OAK-8035_4.patch]  for the changes as per your
suggestions - but you beat me to it . Thanks for the help :)

> Debug logging when two or more indices have same or very close cost amounts doesn't work
in case both indices belong to the same type of Query Index
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OAK-8035
>                 URL: https://issues.apache.org/jira/browse/OAK-8035
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: query
>            Reporter: Nitin Gupta
>            Assignee: Julian Reschke
>            Priority: Major
>             Fix For: 1.12, 1.11.0
>
>         Attachments: OAK-8035.patch, OAK-8035_2.patch, OAK-8035_3.patch, OAK-8035_4.patch
>
>
> Steps to reproduce -
>  # You would need two index definitions of same query index type , let's say fullText
index , having similar cost evaluations.
>  # Now while the index plan is evaluated you will notice that there should have been
a debug log saying that selected index has similar cost - this serves as an important warning
to either change the index definitions or the query ([https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java#L1069#L1072)]
>  
> However If we have a look at this code block here - [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java#L1017#L1041] ,
there is no comparison for near best costs for index plans having same query index type .
>  
> cc : [~teofili]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message