jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-8028) Avoid unnecessary query in UnsavedModifications.persist()
Date Wed, 06 Feb 2019 13:09:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761726#comment-16761726
] 

Marcel Reutegger commented on OAK-8028:
---------------------------------------

[~egli], do you remember why you added the check around the update?

> Avoid unnecessary query in UnsavedModifications.persist()
> ---------------------------------------------------------
>
>                 Key: OAK-8028
>                 URL: https://issues.apache.org/jira/browse/OAK-8028
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>            Priority: Minor
>             Fix For: 1.12
>
>
> Towards the end of a background update, the method {{UnsavedModifications.persist()}}
writes the {{lastWrittenRootRev}} to the clusterNode entry. Before the write, it checks whether
the entry exists for its clusterId. This is unnecessary because {{findAndUpdate()}} will only
perform the update when the document exists.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message