jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-8027) Extract public utility for handling jcr:all privilege bits
Date Thu, 07 Feb 2019 12:40:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762629#comment-16762629

Alex Deparvu commented on OAK-8027:

I tried to follow the changes, and they look good to me (it was a bit of effort).
just 2 minor observations:
* JcrAllUtil: I would replace usage of Longs.asList with Collections.singletonList
* JcrAllUtil.getPropertyState, is not a getter, I would rename it to "asPropertyState" or
something similar

> Extract public utility for handling jcr:all privilege bits
> ----------------------------------------------------------
>                 Key: OAK-8027
>                 URL: https://issues.apache.org/jira/browse/OAK-8027
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security-spi
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>         Attachments: OAK-8027-tests.patch, OAK-8027.patch
> [~stillalex], while working on authorization related PoC i found myself copying the logic
used inside _oak-core_ to store the {{PrivilegeBits}} representation of {{jcr:all}}. Since
that latter is defined to always reflect the aggregation of all registered privileges, which
may change over time, the code in _oak-core_ uses a placeholder value instead. That logic
could be shared by different implementations if it was available in _oak-security-spi_.

This message was sent by Atlassian JIRA

View raw message