jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7182) Make it possible to update Guava
Date Wed, 13 Feb 2019 10:12:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767017#comment-16767017
] 

Alex Deparvu commented on OAK-7182:
-----------------------------------

bq. or to use reflection to support old and new Guava?
I went ahead and added a prototype of this based on the latest patch [0], just to see how
crazy it would look.
I ended up with 2 classes wrapping the guava apis. The executor stuff is still ok [1], but
the toStringHelper is pretty weird [2], we have to remap the entire api footprint, it would
be easier to rewrite it (or just copy the code over).

I hope this gets the discussion moving again, I would love to see this resolved in some way.


[0] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:x-guava-test
[1] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:x-guava-test#diff-f1efb305e741d16201cdc8de18d22569
[2] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:x-guava-test#diff-fd33259bcb6c3e9c1afd3ab17aca2f1d


> Make it possible to update Guava
> --------------------------------
>
>                 Key: OAK-7182
>                 URL: https://issues.apache.org/jira/browse/OAK-7182
>             Project: Jackrabbit Oak
>          Issue Type: Wish
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>         Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, OAK-7182-guava-21-4.diff,
OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they essentially
need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in order to
make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message