From oak-issues-return-66795-archive-asf-public=cust-asf.ponee.io@jackrabbit.apache.org Tue Dec 4 00:15:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 32F5B180645 for ; Tue, 4 Dec 2018 00:15:06 +0100 (CET) Received: (qmail 31599 invoked by uid 500); 3 Dec 2018 23:15:04 -0000 Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-issues@jackrabbit.apache.org Received: (qmail 31429 invoked by uid 99); 3 Dec 2018 23:15:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2018 23:15:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1B3C7C207C for ; Mon, 3 Dec 2018 23:15:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id oXwJXNG8ezO1 for ; Mon, 3 Dec 2018 23:15:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CD77A5F5BA for ; Mon, 3 Dec 2018 23:15:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D4DA8E1013 for ; Mon, 3 Dec 2018 23:15:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6C56224DD8 for ; Mon, 3 Dec 2018 23:15:00 +0000 (UTC) Date: Mon, 3 Dec 2018 23:15:00 +0000 (UTC) From: "Vikas Saurabh (JIRA)" To: oak-issues@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OAK-7929) Incorrect Facet Count With Large Dataset and ACLs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OAK-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707965#comment-16707965 ] Vikas Saurabh commented on OAK-7929: ------------------------------------ Adding * [^0001-OAK-7930-Add-tape-sampling.patch] - which add tape sampling (OAK-7930) * [^0002-OAK-7929-Incorrect-Facet-Count-With-Large-Dataset-an.patch] - rest of implementation as described in the comment above [~tmueller], I'm still writing tests (basically an IT with facets across different configs). But, it'd great if you can review the implementation in the patches. I don't want to commit to trunk before review. Btw, we also need to backport it to 1.8 and 1.6 - but those would need to wait until after I am done with the test (I'd upload backport patches as soon as I get to them). > Incorrect Facet Count With Large Dataset and ACLs > ------------------------------------------------- > > Key: OAK-7929 > URL: https://issues.apache.org/jira/browse/OAK-7929 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene > Reporter: Vikas Saurabh > Assignee: Vikas Saurabh > Priority: Major > Fix For: 1.10 > > Attachments: 0001-OAK-7930-Add-tape-sampling.patch, 0002-OAK-7929-Incorrect-Facet-Count-With-Large-Dataset-an.patch > > > Currently ACL (secure) facet handling only deals with first batch of results from lucene index (50 documents). So, for large result sets, the facet count hence doesn't get decremented for large part of the result set. -- This message was sent by Atlassian JIRA (v7.6.3#76005)