jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7929) Incorrect Facet Count With Large Dataset and ACLs
Date Tue, 04 Dec 2018 13:15:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708684#comment-16708684
] 

Thomas Mueller commented on OAK-7929:
-------------------------------------

The rest of the patch is a bit harder to analyze... Due to modularization, it looks like some
of the test is in a different module than the implementation...

{noformat} 
+    if (propertyState != null) {
+      try {
+        ret = propertyState.getValue(Type.LONG);
+      } catch (Exception e) {
+        // ignored
+      }
{noformat}

I would probably log the exception message at log level debug, and the stack trace at log
level trace.

> Incorrect Facet Count With Large Dataset and ACLs
> -------------------------------------------------
>
>                 Key: OAK-7929
>                 URL: https://issues.apache.org/jira/browse/OAK-7929
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: lucene
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>            Priority: Major
>             Fix For: 1.10
>
>         Attachments: 0001-OAK-7930-Add-tape-sampling.patch, 0002-OAK-7929-Incorrect-Facet-Count-With-Large-Dataset-an.patch
>
>
> Currently ACL (secure) facet handling only deals with first batch of results from lucene
index (50 documents). So, for large result sets, the facet count hence doesn't get decremented
for large part of the result set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message