jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikas Saurabh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7929) Incorrect Facet Count With Large Dataset and ACLs
Date Mon, 03 Dec 2018 23:15:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707965#comment-16707965
] 

Vikas Saurabh commented on OAK-7929:
------------------------------------

Adding
*  [^0001-OAK-7930-Add-tape-sampling.patch]  - which add tape sampling (OAK-7930)
*  [^0002-OAK-7929-Incorrect-Facet-Count-With-Large-Dataset-an.patch]  - rest of implementation
as described in the comment above

[~tmueller], I'm still writing tests (basically an IT with facets across different configs).
But, it'd great if you can review the implementation in the patches. I don't want to commit
to trunk before review. Btw, we also need to backport it to 1.8 and 1.6 - but those would
need to wait until after I am done with the test (I'd upload backport patches as soon as I
get to them).

> Incorrect Facet Count With Large Dataset and ACLs
> -------------------------------------------------
>
>                 Key: OAK-7929
>                 URL: https://issues.apache.org/jira/browse/OAK-7929
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: lucene
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>            Priority: Major
>             Fix For: 1.10
>
>         Attachments: 0001-OAK-7930-Add-tape-sampling.patch, 0002-OAK-7929-Incorrect-Facet-Count-With-Large-Dataset-an.patch
>
>
> Currently ACL (secure) facet handling only deals with first batch of results from lucene
index (50 documents). So, for large result sets, the facet count hence doesn't get decremented
for large part of the result set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message