jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "OrDTesters (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OAK-7891) Fix unexpected test failures caused by DataStoreUtils.testPropertySetup
Date Fri, 09 Nov 2018 23:55:00 GMT

     [ https://issues.apache.org/jira/browse/OAK-7891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

OrDTesters updated OAK-7891:
----------------------------
    Description: 
Tests in oak-blob-plugins will sometimes pass and sometimes fail, even running on the same
version of the code.

These failures are caused by DataStoreUtils.testPropertySetup, which sets a property (DS_CLASS_NAME)
but doesn’t reset it when it’s done. This causes tests in SharedDataStoreUtils, BlobIdTrackerTest,
and BlobIdTrackerClusterSharedTest (14 tests in total) to fail if they run after this test.
 To fix this issue, I have reset the properties set in DataStoreUtils.testPropertySetup to
their values before the test changed them.

To replicate this issue, you can run:
{code:java}
mvn test -Dtest="SharedDataStoreUtilsTest#testRefsNotAvailableAllRepos,DataStoreUtils#testPropertySetup"
-Dsurefire.runOrder=alphabetical{code}
and
{code:java}
mvn test -Dtest="SharedDataStoreUtilsTest#testRefsNotAvailableAllRepos,DataStoreUtils#testPropertySetup"
-Dsurefire.runOrder=reversealphabetical{code}
and see that the results differ.

A link to a pull request which fixes the issue is: https://github.com/apache/jackrabbit-oak/pull/110

  was:
Tests in oak-blob-plugins will sometimes pass and sometimes fail, even running on the same
version of the code. 

These failures are caused by DataStoreUtils.testPropertySetup, which sets a property (DS_CLASS_NAME)
but doesn’t reset it when it’s done. This causes tests in SharedDataStoreUtils, BlobIdTrackerTest,
and BlobIdTrackerClusterSharedTest (14 tests in total) to fail if they run after this test.
To fix this issue, I have reset the properties set in DataStoreUtils.testPropertySetup to
their values before the test changed them.

To replicate this issue, you can run:
{code:java}
mvn test -Dtest="SharedDataStoreUtilsTest#testRefsNotAvailableAllRepos,DataStoreUtils#testPropertySetup"
-Dsurefire.runOrder=alphabetical{code}
and
{code:java}
mvn test -Dtest="SharedDataStoreUtilsTest#testRefsNotAvailableAllRepos,DataStoreUtils#testPropertySetup"
-Dsurefire.runOrder=reversealphabetical{code}
and see that the results differ.


> Fix unexpected test failures caused by DataStoreUtils.testPropertySetup
> -----------------------------------------------------------------------
>
>                 Key: OAK-7891
>                 URL: https://issues.apache.org/jira/browse/OAK-7891
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: blob-plugins
>         Environment: Ubuntu 18.04
> java version "1.8.0_181"
> Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode)
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T13:33:14-05:00)
>            Reporter: OrDTesters
>            Priority: Minor
>
> Tests in oak-blob-plugins will sometimes pass and sometimes fail, even running on the
same version of the code.
> These failures are caused by DataStoreUtils.testPropertySetup, which sets a property
(DS_CLASS_NAME) but doesn’t reset it when it’s done. This causes tests in SharedDataStoreUtils,
BlobIdTrackerTest, and BlobIdTrackerClusterSharedTest (14 tests in total) to fail if they
run after this test.
>  To fix this issue, I have reset the properties set in DataStoreUtils.testPropertySetup
to their values before the test changed them.
> To replicate this issue, you can run:
> {code:java}
> mvn test -Dtest="SharedDataStoreUtilsTest#testRefsNotAvailableAllRepos,DataStoreUtils#testPropertySetup"
-Dsurefire.runOrder=alphabetical{code}
> and
> {code:java}
> mvn test -Dtest="SharedDataStoreUtilsTest#testRefsNotAvailableAllRepos,DataStoreUtils#testPropertySetup"
-Dsurefire.runOrder=reversealphabetical{code}
> and see that the results differ.
> A link to a pull request which fixes the issue is: https://github.com/apache/jackrabbit-oak/pull/110



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message