jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7880) Reduce Principal lookup in default access control code base
Date Mon, 05 Nov 2018 09:51:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674896#comment-16674896

angela commented on OAK-7880:

[~stillalex], proposed patch attached. there was only 1 test failing with the proposed changes:
the test was expecting a specific implementation and not comparing the principal names. wdyt?

> Reduce Principal lookup in default access control code base
> -----------------------------------------------------------
>                 Key: OAK-7880
>                 URL: https://issues.apache.org/jira/browse/OAK-7880
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>         Attachments: AccessControlManagerImpl.java, OAK-7880.patch
> today i spotted to places in {{AccessControlManagerImpl}}, where i think the principal
lookup could be omitted altogether:
> {{a) AccessControlManagerImpl.getPrincipal(Tree)}} : called when building policies from
the content -> principal is always created even if not known.
> b)  {{Util.checkValidPrincipal(Principal, PrincipalManager, int)}} : in case of ImportBehavior.BESTEFFORT
the result of the lookup is ignored and the lookup could in this case be omitted.
> [~stillalex], what do you think? If you feel this is worth addressing, I would create
a patch.

This message was sent by Atlassian JIRA

View raw message