jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Francesco Mari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7877) Avoid unnecessary operations when logging read operations
Date Fri, 02 Nov 2018 13:10:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673081#comment-16673081
] 

Francesco Mari commented on OAK-7877:
-------------------------------------

These are the results for {{ConcurrentCreateNodeTest}} without the patch, with the patch and
logger disabled, and with the patch and logger enabled.

{noformat}
# ConcurrentCreateNodesTest        C     min     10%     50%     90%     max       N 
# Without the patch
Oak-Segment-Tar                    1    1447    1476    1654    1766    1821      38
# With the patch, logger disabled
Oak-Segment-Tar                    1     510     540     734     983    1144      81
# With the patch, logger enabled
Oak-Segment-Tar                    1    6298    6316    6577    6691    6697      10
{noformat}

When the logging was enabled, I used a modified {{logback.xml}} with the following additions:

{noformat}
<appender name="logging-hook" class="ch.qos.logback.core.FileAppender">
    <file>out.log</file>
    <encoder>
        <pattern>%d %msg%n</pattern>
    </encoder>
</appender>
<logger name="org.apache.jackrabbit.oak.segment.LoggingHook.reader" level="TRACE" additivity="false">
    <appender-ref ref="logging-hook" />
</logger>
{noformat}

> Avoid unnecessary operations when logging read operations
> ---------------------------------------------------------
>
>                 Key: OAK-7877
>                 URL: https://issues.apache.org/jira/browse/OAK-7877
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>            Priority: Major
>             Fix For: 1.10
>
>         Attachments: OAK-7877-01.patch
>
>
> The log statements introduced in {{CachingSegmentReader}} by OAK-7864 perform multiple
string concatenations even if that specific log is disabled. The log statements should be
executed only if the right log level has been enabled for that logger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message