From oak-issues-return-65628-archive-asf-public=cust-asf.ponee.io@jackrabbit.apache.org Tue Oct 16 18:07:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 01F5B180674 for ; Tue, 16 Oct 2018 18:07:04 +0200 (CEST) Received: (qmail 93092 invoked by uid 500); 16 Oct 2018 16:07:04 -0000 Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-issues@jackrabbit.apache.org Received: (qmail 93081 invoked by uid 99); 16 Oct 2018 16:07:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Oct 2018 16:07:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2697FC0CCC for ; Tue, 16 Oct 2018 16:07:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id kit9B_CBnduY for ; Tue, 16 Oct 2018 16:07:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B9D025F52B for ; Tue, 16 Oct 2018 16:07:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E1061E2613 for ; Tue, 16 Oct 2018 16:07:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6DC4124DF2 for ; Tue, 16 Oct 2018 16:07:00 +0000 (UTC) Date: Tue, 16 Oct 2018 16:07:00 +0000 (UTC) From: "Andrei Dulceanu (JIRA)" To: oak-issues@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (OAK-7843) oak-upgrade doesn't correctly pass segment cache size to file store MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OAK-7843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652006#comment-16652006 ] Andrei Dulceanu edited comment on OAK-7843 at 10/16/18 4:07 PM: ---------------------------------------------------------------- [~tomek.rekawek], my understanding is that the segment cache size needs to be set only on the source repository, as that is the one doing all the reading, right? Could you take a look at [^OAK-7843.patch] , please? /cc [~mduerig] was (Author: dulceanu): [~tomek.rekawek], my understanding is that the segment cache size needs to be set only on the source repository, as that is the one doing all the reading, right? Could you take a look at the attached patch, please? /cc [~mduerig] [^OAK-7843.patch] > oak-upgrade doesn't correctly pass segment cache size to file store > ------------------------------------------------------------------- > > Key: OAK-7843 > URL: https://issues.apache.org/jira/browse/OAK-7843 > Project: Jackrabbit Oak > Issue Type: Bug > Components: upgrade > Reporter: Andrei Dulceanu > Assignee: Andrei Dulceanu > Priority: Minor > Attachments: OAK-7843.patch > > > When setting a segment cache size via the {{--cache SEGMENT_CACHE_SIZE}} option, {{oak-upgrade}} doesn't correctly pass it to the file store, although it correctly logs the value right after start. Below meaningful lines from the log, when trying to set a segment cache of 8GB: > {noformat} > [...] > 16.10.2018 17:00:29.834 [main] *INFO* org.apache.jackrabbit.oak.upgrade.cli.parser.MigrationOptions - Cache size: 8192 MB > [..] > 16.10.2018 17:00:30.144 [main] *INFO* org.apache.jackrabbit.oak.segment.file.FileStore - Creating file store FileStoreBuilder{version=1.10-SNAPSHOT, directory=repository/segmentstore, blobStore=org.apache.jackrabbit.oak.upgrade.cli.blob.LoopbackBlobStore@33b37288, maxFileSize=256, segmentCacheSize=256, stringCacheSize=256, templateCacheSize=64, stringDeduplicationCacheSize=15000, templateDeduplicationCacheSize=3000, nodeDeduplicationCacheSize=1048576, memoryMapping=false, gcOptions=SegmentGCOptions{paused=false, estimationDisabled=false, gcSizeDeltaEstimation=1073741824, retryCount=5, forceTimeout=60, retainedGenerations=2, gcType=FULL}} > {noformat} > It can be observed that the segment cache size remained at 256MB (default). -- This message was sent by Atlassian JIRA (v7.6.3#76005)