jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Ryan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7818) [DirectBinaryAccess] AzureDataStore not chaining exceptions on upload completion
Date Wed, 10 Oct 2018 15:48:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645169#comment-16645169
] 

Matt Ryan commented on OAK-7818:
--------------------------------

See [https://github.com/apache/jackrabbit-oak/blob/a892ff4215dd2703e5f617c3dd00f3acc402004d/oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackend.java#L951] for
an example of the offending code.  Notice that the caught exception isn't included when constructing
the new one to be thrown.

> [DirectBinaryAccess] AzureDataStore not chaining exceptions on upload completion
> --------------------------------------------------------------------------------
>
>                 Key: OAK-7818
>                 URL: https://issues.apache.org/jira/browse/OAK-7818
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: blob-cloud-azure
>    Affects Versions: 1.9.9
>            Reporter: Matt Ryan
>            Assignee: Matt Ryan
>            Priority: Minor
>              Labels: easyfix
>
> In {{AzureBlobStoreBackend#completeHttpUpload()}}, the code catches {{StorageException}}
and {{URISyntaxException}} as thrown by the Azure SDK, but this exception is not chained in
the {{DataStoreException}} that is thrown if those exceptions are caught, which makes it more
difficult to diagnose the real issue behind the {{DataStoreException}}.
> This was just a simple oversight in the original implementation.  We should also examine
the other code related to direct binary access, both in the Azure and S3 implementations,
to see if there are any other similar bugs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message