jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Ryan (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-7807) [S3DataStore] S3DataStore unit tests not deleting buckets created during test
Date Fri, 12 Oct 2018 19:13:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648060#comment-16648060
] 

Matt Ryan edited comment on OAK-7807 at 10/12/18 7:12 PM:
----------------------------------------------------------

{quote}Aren't the names like {{5408-6709-test}} distinguishing themselves from other names?
{quote}
My feeling is that if you know the unit test code you can make a pretty good guess that this
bucket was created by the unit test, but if you are an S3 account administrator, not aware
of the S3 data store unit tests, you wouldn't know by looking at the bucket what it was for. 
You might still think it could be created by a person and therefore you shouldn't just remove
it.

My argument is that naming it {{5408-6708-s3ds-unittest-autogenerated}} makes it pretty clear
that this bucket was automatically created by a unit test and probably was left by accident.

WDYT?  If you don't think the name change makes sense I'm okay with leaving it but I do prefer
the longer name for the reason mentioned.  I tend to be overly verbose however...


was (Author: mattvryan):
{quote}Aren't the names like {{5408-6709-test}} distinguishing themselves from other names?
{quote}
My feeling is that if you know the unit test code you can make a pretty good guess that this
bucket was created by the unit test, but if you are an S3 account admin you wouldn't know
by looking at the bucket what it was for.  You might still think it could be created by a
person and therefore you shouldn't just remove it.

My argument is that naming it {{5408-6708-s3ds-unittest-autogenerated}} makes it pretty clear
that this bucket was automatically created by a unit test and probably was left by accident.

WDYT?  If you don't think the name change makes sense I'm okay with leaving it but I do prefer
the longer name for the reason mentioned.  I tend to be overly verbose however...

> [S3DataStore] S3DataStore unit tests not deleting buckets created during test
> -----------------------------------------------------------------------------
>
>                 Key: OAK-7807
>                 URL: https://issues.apache.org/jira/browse/OAK-7807
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: blob-cloud
>    Affects Versions: 1.9.8
>            Reporter: Matt Ryan
>            Assignee: Matt Ryan
>            Priority: Major
>         Attachments: OAK-7807.patch, OAK-7807.patch.2
>
>
> It appears that when the S3DataStore tests run they are not properly cleaning up S3 buckets
that were created during the execution of the test.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message