From oak-issues-return-64516-archive-asf-public=cust-asf.ponee.io@jackrabbit.apache.org Thu Aug 30 15:55:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 505A1180675 for ; Thu, 30 Aug 2018 15:55:04 +0200 (CEST) Received: (qmail 57670 invoked by uid 500); 30 Aug 2018 13:55:02 -0000 Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-issues@jackrabbit.apache.org Received: (qmail 57389 invoked by uid 99); 30 Aug 2018 13:55:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Aug 2018 13:55:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 73868C6E21 for ; Thu, 30 Aug 2018 13:55:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fLJoEwr6xbIg for ; Thu, 30 Aug 2018 13:55:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 429705F3AA for ; Thu, 30 Aug 2018 13:55:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7F026E00D3 for ; Thu, 30 Aug 2018 13:55:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 405C22183D for ; Thu, 30 Aug 2018 13:55:00 +0000 (UTC) Date: Thu, 30 Aug 2018 13:55:00 +0000 (UTC) From: "Francesco Mari (JIRA)" To: oak-issues@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OAK-7720) Log hex dump of too big segments MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OAK-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597485#comment-16597485 ] Francesco Mari commented on OAK-7720: ------------------------------------- The first version of the patch prints a single warn log statement containing a message, some metadata about the segment and the hex dump of the segment buffer. The message is quite verbose because of the hex dump, but I think it's an acceptable price to pay in order to efficiently identify segment corruptions. [~mduerig], [~dulceanu], can you review? > Log hex dump of too big segments > -------------------------------- > > Key: OAK-7720 > URL: https://issues.apache.org/jira/browse/OAK-7720 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: segment-tar > Reporter: Francesco Mari > Assignee: Francesco Mari > Priority: Major > Attachments: OAK-7720-01.patch > > > {{SegmentBufferWriter}} throws an ISE when it detects that a too big segment is about to be flushed. The ISE contains some details about the segment, like the amount of referenced segments, the amount of records, they payload length and the total length, but they are insufficient. {{SegmentBufferWriter}} should print a hex dump of the segment to the logger in order to speed up the debugging of this error condition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)