jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-7720) Log hex dump of too big segments
Date Fri, 31 Aug 2018 09:56:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598526#comment-16598526
] 

Michael Dürig commented on OAK-7720:
------------------------------------

LGTM.

Re. making that method safer: I was thinking to just wrap everything in {{SegmentBufferWriter#dumpSegmentBuffer}}
into a catch all try-catch block. But maybe I'm overly paranoid here. 

> Log hex dump of too big segments
> --------------------------------
>
>                 Key: OAK-7720
>                 URL: https://issues.apache.org/jira/browse/OAK-7720
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>            Priority: Major
>         Attachments: OAK-7720-01.patch, OAK-7720-02.patch
>
>
> {{SegmentBufferWriter}} throws an ISE when it detects that a too big segment is about
to be flushed. The ISE contains some details about the segment, like the amount of referenced
segments, the amount of records, they payload length and the total length, but they are insufficient.
{{SegmentBufferWriter}} should print a hex dump of the segment to the logger in order to speed
up the debugging of this error condition.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message