From oak-issues-return-63591-archive-asf-public=cust-asf.ponee.io@jackrabbit.apache.org Thu Jul 19 14:28:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EC8AE180630 for ; Thu, 19 Jul 2018 14:28:03 +0200 (CEST) Received: (qmail 53872 invoked by uid 500); 19 Jul 2018 12:28:03 -0000 Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-issues@jackrabbit.apache.org Received: (qmail 53861 invoked by uid 99); 19 Jul 2018 12:28:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jul 2018 12:28:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A0C6E18067E for ; Thu, 19 Jul 2018 12:28:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Kure1wvK2f2P for ; Thu, 19 Jul 2018 12:28:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 590305F48B for ; Thu, 19 Jul 2018 12:28:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 901E1E00C6 for ; Thu, 19 Jul 2018 12:28:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 586112713F for ; Thu, 19 Jul 2018 12:28:00 +0000 (UTC) Date: Thu, 19 Jul 2018 12:28:00 +0000 (UTC) From: "Vikas Saurabh (JIRA)" To: oak-issues@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (OAK-7630) Suggest directory update doesn't close AnalyzingInfixSuggester after building MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OAK-7630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542344#comment-16542344 ] Vikas Saurabh edited comment on OAK-7630 at 7/19/18 12:27 PM: -------------------------------------------------------------- Fixed on trunk at [r1835780|https://svn.apache.org/r1835780]. -Would backport to 1.8 branch after a few cycles of testing.- Backported to 1.8 at [r1836267|https://svn.apache.org/r1836267]. was (Author: catholicon): Fixed on trunk at [r1835780|https://svn.apache.org/r1835780]. Would backport to 1.8 branch after a few cycles of testing. > Suggest directory update doesn't close AnalyzingInfixSuggester after building > ----------------------------------------------------------------------------- > > Key: OAK-7630 > URL: https://issues.apache.org/jira/browse/OAK-7630 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene > Affects Versions: 1.8.0 > Reporter: Vikas Saurabh > Assignee: Vikas Saurabh > Priority: Major > Fix For: 1.10, 1.9.6, 1.8.6 > > > {{SuggestHelper#updateSuggester}} updates suggester by doing a {{build()}} on a newly created instance of {{AnalyzingInfixSuggester}}. But it never closes the suggester instance, which, in turn, leads to un-closed reader. With FS based directory (when copy-on-write is enabled), this leads to leaking file handles. FSDirectory does get closed on GC though. > The issue was reported by [~mreutegg] -- This message was sent by Atlassian JIRA (v7.6.3#76005)