From oak-issues-return-63431-archive-asf-public=cust-asf.ponee.io@jackrabbit.apache.org Tue Jul 17 08:28:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 08A3E18067A for ; Tue, 17 Jul 2018 08:28:03 +0200 (CEST) Received: (qmail 30699 invoked by uid 500); 17 Jul 2018 06:28:03 -0000 Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-issues@jackrabbit.apache.org Received: (qmail 30686 invoked by uid 99); 17 Jul 2018 06:28:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jul 2018 06:28:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 897711A0F09 for ; Tue, 17 Jul 2018 06:28:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ZfrF2ouNFGOj for ; Tue, 17 Jul 2018 06:28:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1E5AD5F3BC for ; Tue, 17 Jul 2018 06:28:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 660B4E02BE for ; Tue, 17 Jul 2018 06:28:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1D02323F9A for ; Tue, 17 Jul 2018 06:28:00 +0000 (UTC) Date: Tue, 17 Jul 2018 06:28:00 +0000 (UTC) From: "Marcel Reutegger (JIRA)" To: oak-issues@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (OAK-7589) [DirectBinaryAccess][DISCUSS] Client facing API MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OAK-7589?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D165455= 38#comment-16545538 ]=20 Marcel Reutegger edited comment on OAK-7589 at 7/17/18 6:27 AM: ---------------------------------------------------------------- I made a few more changes on top of your PR. See my [OAK-7589 branch|https:= //github.com/mreutegg/jackrabbit/tree/OAK-7589], though the github website = is currently down for me. I also left a few TODOs. What do you think about = those? I was also wondering if {{BinaryDirectDownload}} and {{BinaryDirectUpload}}= should be renamed to simply {{BinaryDownload}} and {{BinaryUpload}}. This = would better match {{JackrabbitValueFactory.initiateBinaryUpload()}}. Furth= ermore, simplify {{getDownloadURI()}} to {{getURI()}}? The term download is= already present in the name of the interface. was (Author: mreutegg): I made a few more changes on top of your PR. See my [OAK-7589 branch|https:= //github.com/mreutegg/jackrabbit-oak/tree/OAK-7589], though the github webs= ite is currently down for me. I also left a few TODOs. What do you think ab= out those? I was also wondering if {{BinaryDirectDownload}} and {{BinaryDirectUpload}}= should be renamed to simply {{BinaryDownload}} and {{BinaryUpload}}. This = would better match {{JackrabbitValueFactory.initiateBinaryUpload()}}. Furth= ermore, simplify {{getDownloadURI()}} to {{getURI()}}? The term download is= already present in the name of the interface. > [DirectBinaryAccess][DISCUSS] Client facing API > ----------------------------------------------- > > Key: OAK-7589 > URL: https://issues.apache.org/jira/browse/OAK-7589 > Project: Jackrabbit Oak > Issue Type: Technical task > Reporter: Matt Ryan > Assignee: Matt Ryan > Priority: Major > > From a discussion w/ [~mreutegg]:=C2=A0 Suggested that we move the API ch= anges out of oak-jcr (i.e. org.apache.jackrabbit.oak.jcr.api.binary.HttpBin= aryProvider and org.apache.jackrabbit.oak.jcr.api.binary.HttpBinaryDownload= to a different package to avoid unnecessary API changes to oak-jcr. > This issue should also be used to discuss how exactly the client facing A= PI is designed.=20 -- This message was sent by Atlassian JIRA (v7.6.3#76005)