jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Egli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7626) Strict lease check mode
Date Thu, 12 Jul 2018 12:09:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541531#comment-16541531
] 

Stefan Egli commented on OAK-7626:
----------------------------------

Sure, looks good to me. I was only stumbling upon 1 issue but re-reading clarified it, here
for reference:
* I first thought it odd that in [setLeaseCheck|https://github.com/apache/jackrabbit-oak/compare/trunk...mreutegg:OAK-7626#diff-842f2d7d031f3b70bc427b9d743c81d7R235]
the default is LENIENT, but IIUC then that's only used in testing now, the only productive
code case has been changed to {{setLeaseCheckMode(STRICT|DISABLED)}}, so that looks fine to
me


> Strict lease check mode
> -----------------------
>
>                 Key: OAK-7626
>                 URL: https://issues.apache.org/jira/browse/OAK-7626
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: documentmk
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>            Priority: Major
>             Fix For: 1.10
>
>
> Introduce a strict lease check mode. This is a prerequisite for OAK-3883.
> In strict mode, the lease check must not renew the lease when it is considered as expired.
The current implementation, which permits a renew even when the lease expired, may still be
useful for development when the JVM is in debug mode, but the strict mode should be the new
default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message