jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-5357) StringUtils conversion functions can throw NullPointerException
Date Wed, 21 Dec 2016 08:40:58 GMT

    [ https://issues.apache.org/jira/browse/OAK-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766487#comment-15766487
] 

Michael Dürig commented on OAK-5357:
------------------------------------

Thanks for sending a patch. I agree we need to clarify and enforce the contract wrt. nullability.
I would prefer to use @Nonnull etc. annotations and {{Preconditions}} (from Guava) to be consistent
with most of the rest of Oak though. Could you update the patch to that respect? 

> StringUtils conversion functions can throw NullPointerException
> ---------------------------------------------------------------
>
>                 Key: OAK-5357
>                 URL: https://issues.apache.org/jira/browse/OAK-5357
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: commons
>    Affects Versions: 1.5.16
>            Reporter: Matt Ryan
>            Priority: Minor
>         Attachments: OAK-5357.1.patch
>
>
> In the {{StringUtils}} class in {{oak-commons}}, the methods {{convertBytesToHex()}}
and {{convertHexToBytes()}} can throw NullPointerException if the argument passed in is null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message