jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-4978) Expose maintainence related MBeans for Segment NodeStores created via factory
Date Wed, 14 Dec 2016 05:16:58 GMT

    [ https://issues.apache.org/jira/browse/OAK-4978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747310#comment-15747310
] 

Chetan Mehrotra commented on OAK-4978:
--------------------------------------

Looks good. Few comments

* Disable dispatch changes here also if its not primary
{code}
        if (isStandbyInstance(context)) {
            segmentNodeStoreBuilder.dispatchChanges(false);
        }
{code}
* SharedDataStoreUtils - Logic related to initializing the clusterId for SharedDataStore support
should also be locked for primary
* Include the role info in above log so that log is not ambiguous around which store is being
used
{code}
log.info("SegmentNodeStore initialized");
{code}
* Repository discriptors registration - Looking at SegmentNodeStoreFactory it looks like there
is an explicit option for registering the descriptors. So this logic need not be locked for
primary store but be controlled via {{descriptors}} parameter value
{code}
 if (descriptors && isPrimarySegmentStore(role)) {
{code}
* May be add {{role}} as a service property while exposing the  {{SegmentStoreProvider}}
{code}
// Register a factory service to expose the FileStore
        registrations.register(asCloseable(whiteboard.register(
                SegmentStoreProvider.class,
                new DefaultSegmentStoreProvider(store),
                Collections.emptyMap()
        )));
{code}

> Expose maintainence related MBeans for Segment NodeStores created via factory
> -----------------------------------------------------------------------------
>
>                 Key: OAK-4978
>                 URL: https://issues.apache.org/jira/browse/OAK-4978
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar, segmentmk
>            Reporter: Chetan Mehrotra
>            Assignee: Francesco Mari
>             Fix For: 1.6, 1.5.16
>
>         Attachments: OAK-4978-02.patch, OAK-4978.patch
>
>
> With OAK-4655 support was added to initializing multiple segment nodestores and have
them exposed via {{NodeStoreProvider}} ties to different roles.
> In some cases such stores are immutable and do not require any maintenance. However for
other cases maintenance is required. So we would need to expose various MBean which allow
such maintenance activities.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message