Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Date: Mon, 1 Aug 2016 13:46:20 +0000 (UTC)
From: "Andrei Dulceanu (JIRA)" <jira@apache.org>
To: oak-issues@jackrabbit.apache.org
Message-ID: <JIRA.12991135.1469024683000.186423.1470059180784@Atlassian.JIRA>
In-Reply-To: <JIRA.12991135.1469024683000@Atlassian.JIRA>
References: <JIRA.12991135.1469024683000@Atlassian.JIRA> <JIRA.12991135.1469024683257@arcas>
Subject: [jira] [Updated] (OAK-4579) Improve FileStore.size calculation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 01 Aug 2016 13:46:22 -0000


     [ https://issues.apache.org/jira/browse/OAK-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Dulceanu updated OAK-4579:
---------------------------------
    Attachment:     (was: OAK-4579-01.patch)

> Improve FileStore.size calculation
> ----------------------------------
>
>                 Key: OAK-4579
>                 URL: https://issues.apache.org/jira/browse/OAK-4579
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>              Labels: resilience
>             Fix For: Segment Tar 1.0.0
>
>         Attachments: OAK-4579-01.patch
>
>
> A new approach for calculating {{FileStore::size}} is needed because this method is prone to lock contention and should not be called too often.
> The steps to implement the approach are:
> # reduce the lock surface of the size() method. This should be simple enough by creating a copy of the readers / writer inside the lock and do the actual size calculation on that snapshot but outside of the lock.
> # lower size() visibility to package to avoid misuse (from monitoring tools)
> # remove {{approximateSize}} and associated logic and replace it with {{size()}}.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)