Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4D0D2200B7F for ; Tue, 2 Aug 2016 07:13:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4BD8F160AAE; Tue, 2 Aug 2016 05:13:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ABF78160AAB for ; Tue, 2 Aug 2016 07:13:21 +0200 (CEST) Received: (qmail 21724 invoked by uid 500); 2 Aug 2016 05:13:20 -0000 Mailing-List: contact oak-issues-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-issues@jackrabbit.apache.org Received: (qmail 21642 invoked by uid 99); 2 Aug 2016 05:13:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2016 05:13:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8D9E52C0D67 for ; Tue, 2 Aug 2016 05:13:20 +0000 (UTC) Date: Tue, 2 Aug 2016 05:13:20 +0000 (UTC) From: "Amit Jain (JIRA)" To: oak-issues@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (OAK-4454) Create consistent API in ExternalSort to write and read escaped line breaks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 02 Aug 2016 05:13:22 -0000 [ https://issues.apache.org/jira/browse/OAK-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Jain updated OAK-4454: --------------------------- Fix Version/s: 1.2.18 > Create consistent API in ExternalSort to write and read escaped line breaks > --------------------------------------------------------------------------- > > Key: OAK-4454 > URL: https://issues.apache.org/jira/browse/OAK-4454 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: commons > Reporter: Amit Jain > Assignee: Amit Jain > Priority: Minor > Fix For: 1.5.5, 1.4.6, 1.2.18 > > > ExternalSort while sorting uses {{EscapeUtils.unescapeLineBreaks}} to read lines. It is better if a new API is created with explicit expectations documented that the File being sorted has been properly escaped with {{EscapeUtils.escapeLineBreak}}. > Otherwise, it will lead to situations like OAK-4441 where File is not escaped while writing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)