jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig <mdue...@apache.org>
Subject Re: svn commit: r1583285 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueImpl.java
Date Tue, 01 Apr 2014 13:29:59 GMT
3rd try: http://svn.apache.org/r1583661

Michael

On 1 April 2014 05:56, Chetan Mehrotra <chetan.mehrotra@gmail.com> wrote:
> +1. I also missed getting a clean way to get blobId from Blob. So
> adding this method would be useful in other cases also
> Chetan Mehrotra
>
>
> On Tue, Apr 1, 2014 at 8:05 AM, Jukka Zitting <jukka.zitting@gmail.com> wrote:
>> Hi,
>>
>> On Mon, Mar 31, 2014 at 3:25 PM, Michael Dürig <mduerig@apache.org> wrote:
>>> 2nd try: http://svn.apache.org/r1583413
>>
>> That's more correct, but has horrible performance with any
>> implementation (including BlobStoreBlob and SegmentBlob) that doesn't
>> precompute the hash.
>>
>> As mentioned earlier, a better alternative would be to add an explicit
>> method for this and let the implementations decide what the best
>> identifier would be.
>>
>> For BlobStoreBlob that would likely be:
>>
>>     public String getContentIdentity() {
>>         return blobId;
>>     }
>>
>> And for SegmentBlob:
>>
>>     public String getContentIdentity() {
>>         return getRecordId().toString();
>>     }
>>
>> BR,
>>
>> Jukka Zitting

Mime
View raw message