jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Reschke <julian.resc...@gmx.de>
Subject Re: Current approach of creating H2 DB in RDBDocumentStore might cause issue
Date Wed, 26 Mar 2014 09:16:06 GMT
On 2014-03-26 08:46, Chetan Mehrotra wrote:
> Hi Julian,
>
> Currently RDBDocumentStore creates a H2 DB with following url
> -----
> String jdbcurl = "jdbc:h2:file:./target/oaknodes";
> DataSource ds = RDBDataSourceFactory.forJdbcUrl(jdbcurl, "sa", "");
> -----
>
> I think this logic should be part of testcode such that test code can
> clean db file. Currently these db files once created would be reused
> in other test and that might cause issue and some RDB related testcase
> to fail.

Yes, I'll have a look.

> Ideally RDBDocumentStore should just take DataSource and not create it itself.

Yes, it's a leftover. Will get there.

Best regards, Julian


Mime
View raw message