Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D110E101A1 for ; Wed, 12 Feb 2014 14:27:43 +0000 (UTC) Received: (qmail 78523 invoked by uid 500); 12 Feb 2014 14:27:43 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 77326 invoked by uid 500); 12 Feb 2014 14:27:33 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 77312 invoked by uid 99); 12 Feb 2014 14:27:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Feb 2014 14:27:30 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of alex.parvulescu@gmail.com designates 209.85.128.170 as permitted sender) Received: from [209.85.128.170] (HELO mail-ve0-f170.google.com) (209.85.128.170) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Feb 2014 14:27:24 +0000 Received: by mail-ve0-f170.google.com with SMTP id cz12so7530179veb.29 for ; Wed, 12 Feb 2014 06:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=81Tm8/znQrydV6c2O8N+Qw5rBWFTGCgYF14vx5Qt4KY=; b=P+jSeRnmSCoJZ3/5USMv7JLx8vC9mxBzRl0rmhXrVgguRwRg6NX61/yYshiM2BBGiF M5AIN3iCi7hmroFzqbBv8xEX3PcVi5mjzuFW/bmgjHdeJVyDPJ3LwZ/OHfFq5YnvlE+b Ukh1F6eEjtn+MUhdZUttr2WtkeANnjUhh4QNOyIRDhNBMw4rfs6yBUd3ss8PMtUWAF79 wz60g3JqdZmXhsAoorfrtBmokVulatbXSBhhZIDlIYHtPlXg9L0yoCIKT7i/l+yNpl7L FUGw/jGKSYmESSFYjvzFz8fFBIdfYRN9w62yKZBkWErEfm7IQ8drYO/19Uj8TNi+PFIz u8gw== MIME-Version: 1.0 X-Received: by 10.220.48.194 with SMTP id s2mr181924vcf.43.1392215224100; Wed, 12 Feb 2014 06:27:04 -0800 (PST) Received: by 10.220.91.68 with HTTP; Wed, 12 Feb 2014 06:27:04 -0800 (PST) Date: Wed, 12 Feb 2014 15:27:04 +0100 Message-ID: Subject: Promote a close/dispose method to the NodeStore api From: Alex Parvulescu To: oak-dev@jackrabbit.apache.org Content-Type: multipart/alternative; boundary=001a11c1e7fce22ea904f2365d18 X-Virus-Checked: Checked by ClamAV on apache.org --001a11c1e7fce22ea904f2365d18 Content-Type: text/plain; charset=ISO-8859-1 Hi, I was looking at the OakRepositoryFixture and it looks like all the NodeStore flavors have some kind of close/dispose method. Shouldn't we merge this under a single method name, and put it on the apis? I have no direct need for this, just making an observation. thanks, alex [0] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/fixture/OakRepositoryFixture.java --001a11c1e7fce22ea904f2365d18--