jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Angela Schreiber <anch...@adobe.com>
Subject Re: Slow default methods in abstract classes
Date Thu, 06 Feb 2014 09:52:11 GMT
sounds like a plan.


On 06/02/14 10:45, "Thomas Mueller" <mueller@adobe.com> wrote:

>We have some abstract classes that implement some methods for convenience.
>For example, AbstractBlob.equals() is implemented by comparing all bytes
>of a blob, which is very slow (OAK-1392). Or
>Because we forgot(?) to override those methods, we sometimes ended up with
>very slow performance.
>I would prefer if the implementations in the abstract classes are not
>slow. Instead, I would prefer if such methods would be abstract or not
>implemented (in the case of equals). If a "convenience" implementation is
>useful, but slow, it should have a different name, for example
>"equalsBruteForce" or
>That way, a non-abstract implementation could still use the default (slow)
>implementation (for example for the in-memory case, or if the amount of
>data is known to be small), but it would have to do that explicitly.

View raw message